Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated handling of old Plugin.setup signature #1953

Merged
merged 5 commits into from Jan 20, 2022
Merged

Remove deprecated handling of old Plugin.setup signature #1953

merged 5 commits into from Jan 20, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Jan 11, 2022

This PR is a follow-up to PR #1581.
Removes support for the old (deprecated) signature for Launcher.setup and Sweeper.setup

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2022
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 11, 2022

This pull request fixes 1 alert when merging f2d2c2c into 7751c9b - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 11, 2022

This pull request fixes 1 alert when merging fa0df8a into 7751c9b - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@Jasha10 Jasha10 marked this pull request as ready for review January 11, 2022 18:21
@Jasha10 Jasha10 requested a review from jieru-hu January 13, 2022 09:33
@Jasha10 Jasha10 mentioned this pull request Jan 13, 2022
Merged
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jan 13, 2022

This pull request fixes 1 alert when merging 624e5c2 into 8c038c6 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

jieru-hu
jieru-hu approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jieru-hu jieru-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for taking care of this!

@Jasha10 Jasha10 merged commit dd2783d into facebookresearch:main Jan 20, 2022
@Jasha10 Jasha10 deleted the followup1581_2 branch January 20, 2022 19:25
MattiasDC pushed a commit to MattiasDC/hydra that referenced this pull request Apr 1, 2022
@Jasha10 @MattiasDC
Remove deprecated handling of old Plugin.setup signature (facebookres…
a0ade21 
…earch#1953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieru-hu jieru-hu jieru-hu approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jasha10 @jieru-hu @facebook-github-bot