Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mephisto incompatible with Python 3.11 #924

Closed
JackUrb opened this issue Nov 4, 2022 · 2 comments · Fixed by #925
Closed

Mephisto incompatible with Python 3.11 #924

JackUrb opened this issue Nov 4, 2022 · 2 comments · Fixed by #925

Comments

@JackUrb
Copy link
Contributor

JackUrb commented Nov 4, 2022

Overview

Thanks to a change in Python 3.11 (addressed here: facebookresearch/hydra#2418) Mephisto currently doesn't work on Python 3.11.

We should have some kind of grid-test for support on individual python versions (we have this somewhat) but only run on main commits.
@pringshia
Copy link
Contributor

pringshia commented Nov 6, 2022 •
edited

The matrix tests actually run scheduled not on push, once a week.

The versions the test are hardcoded though: https://github.com/facebookresearch/Mephisto/actions/runs/3402202258/workflow#L24

I'll have to see if there's a way to dynamically include newer versions as they release, the easiest thing might just be to test against latest.

@pringshia pringshia mentioned this issue Nov 7, 2022
Merged
@pringshia
Copy link
Contributor

FYI - seems like the Hydra downstream issue should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additional python versions to test facebookresearch/Mephisto
2 participants
@pringshia @JackUrb