For --google_style, break between ( and long condition expressions #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
nreid260
changed the title
nreid260
force-pushed
the
if_cond
branch
2 times, most recently
from
3b526b9
to
4ce0ae6
Compare
|
Importing for easier review |
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
strulovich
requested changes
Jun 7, 2022
Comment on lines
701
to
725
| private fun emitKeywordWithCondition(keyword: String, condition: KtExpression?) { | ||
| if (condition == null) { | ||
| builder.token(keyword) | ||
| return | ||
| } | ||
|
|
||
| builder.block(ZERO) { | ||
| builder.token(keyword) | ||
| builder.space() | ||
| builder.token("(") | ||
| if (isGoogleStyle) { | ||
| builder.block(expressionBreakIndent) { | ||
| builder.breakOp(Doc.FillMode.UNIFIED, "", ZERO) | ||
| visit(condition) | ||
| builder.breakOp(Doc.FillMode.UNIFIED, "", expressionBreakNegativeIndent) | ||
| } | ||
| } else { | ||
| builder.block(ZERO) { | ||
| visit(condition) | ||
| } | ||
| } | ||
| } | ||
| builder.token(")") | ||
| } | ||
|
|
There was a problem hiding this comment.
We organize methods by chronological order if possible, so caller before callee. Could you move these below all callers?
| @@ -698,6 +698,31 @@ class KotlinInputAstVisitor( | |||
| return extractCallExpression(this)?.lambdaArguments?.isNotEmpty() ?: false | |||
| } | |||
|
|
|||
| private fun emitKeywordWithCondition(keyword: String, condition: KtExpression?) { | |||
There was a problem hiding this comment.
Please add a KDoc.
We usually state example of the content this parses, so something alike:
/** Emits a key word followed by a condition, e.g. `if (b)` or `while (c <d )` */
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319