{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":426331021,"defaultBranch":"main","name":"reverie","ownerLogin":"facebookexperimental","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-11-09T17:53:00.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/12853545?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1700668494.0","currentOid":""},"activityList":{"items":[{"before":"407899245d16364c7dffd4506572f2624d000ea1","after":"d2480c7e87816adba5081c186c6874a56a08551d","ref":"refs/heads/main","pushedAt":"2024-05-03T15:04:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade to 0.21.1\n\nSummary:\nNOTE: If your `hg bisect` brings you here & the error you are seeing looks like ` expected Result<&PyAny, PyErr>, found Result, PyErr>` then see these [migration notes](https://pyo3.rs/v0.21.0/migration.html#from-020-to-021) for the fix or click on `fbcode/security/ace/pyo3/authz.rs` or similar files from bellow to see what the fix is!\n\nIn order to upgrade `pyo3` to [`0.21.1`](https://github.com/PyO3/pyo3/releases/tag/v0.21.1), the following had to take place:\n\n## [PyO3]\n* Address [migration notes](https://pyo3.rs/v0.21.0/migration.html#from-020-to-021) for `Bound<'py, T>`\n* Address [#3595](https://github.com/PyO3/pyo3/pull/3595) - this is done in a crude way for now since there are many call sites depending on `fbcode/dba/rust/common/service_address/py/pyo3_conversion_helper.rs` which would require a more thorough review.\n* Address [#3821](https://github.com/PyO3/pyo3/pull/3821) - `pyo3-build-config` is now dependent on and used by PyO3 macros. Currently, the only thing that gets checked is `abi3` compatibility. To address that, we introduce a fixup for that automatically generate `pyo3-build-config*.txt` configuration files, given an `fbsource` Python version. We are tryin to stay as close to `pyo3-build-config*.txt` spec as possible even though only a single bool from that file is ever since there is validation for the other fields but also to future proof future changes. By also generating this file ourselves, we prevent PyO3 from attempting to locate a Python interpreter some other way which seems to start leaking into the PyO3 API as an implementation choice already.\n\n## [PyPi + Rust]\n* Upgrade `orjson` to [`3.10.1`](https://github.com/ijl/orjson/releases/tag/3.10.1)\n * Added `README.md` notes for future upgrades\n* Upgrade `py-polars` to [`0.20.22`](https://github.com/pola-rs/polars/releases/tag/py-0.20.22)\n * Removed `py-polars` and `polars` from `target_os = \"windows\"`. The `third-party/pypi/polars` Python extension has only been supported for Mac and Linux for a while now so its only natural to do that on the Rust side as well. What is more, `polars-util` is bringing in `stacker = = \"0.1.14\"` which does not build on Windows mostly because its using a much more recent version of `libc` than we use in `third-party/rust` (see P1228807344)\n* Upgrade `pydantic-core` to [`2.18.2`](https://github.com/pydantic/pydantic-core/releases/tag/v2.18.2)\n * Removed old `third-party/pypi/pydantic-core` versions\n* Upgrade `safetensors` to [`0.4.3`](https://github.com/huggingface/safetensors/releases/tag/v0.4.3)\n* Patch `third-party/pypi/cryptography/41.0.7` to account for PyO3's [#2975](https://github.com/PyO3/pyo3/pull/2975) (`0.19.0`) where `pyo3::once_cell` was renamed to `pyo3::sync` (see D56826865)\n* Upgrade `tokenizers` and `tokenizers-python` to [`0.19.1`](https://github.com/huggingface/tokenizers/releases/tag/v0.19.1)\n * Removed old `third-party/pypi/tokenizers` versions\n * Fixed `third-party/pypi/tokenizers/BUCK`\n * Migrated `third-party/pypi/tokenizers/0.19.1/BUCK` to mirror other Python packages that bind to Rust crates e.g. `libcst`, `polars` etc.\n * Removed Windows support from `third-party/pypi/tokenizers`\n\n## [Rust]\n* Upgrade `indexmap` to [`2.2.6`](https://github.com/indexmap-rs/indexmap/releases/tag/2.2.6)\n * Both latest `pydantic-core` and `c2pa` depend on `serde_json > 1.0.112` which brings in `indexmap = 2.2.1`. The latter has deprecated `.take` and `.remove` on both `IndexMap` and `IndexSet` leading to a bunch of errors (see bellow), all addressed:\n\n```bash\nerror: use of deprecated method `indexmap::set::IndexSet::::take`: `take` disrupts the set order -- use `swap_take` or `shift_take` for explicit behavior.\n --> fbcode/hphp/hack/src/package/types.rs:76:16\n |\n76 | self.0.take(value)\n | ^^^^\n |\n = note: `-D deprecated` implied by `-D warnings`\n = help: to override `-D warnings` add `#[allow(deprecated)]`\n```\n\nReviewed By: capickett\n\nDifferential Revision: D56671179\n\nfbshipit-source-id: 3ae69c069b7f005570c1a06d37194cf056282a18","shortMessageHtmlLink":"upgrade to 0.21.1"}},{"before":"374247cc0af2b866ea87d449b0a014df46f54ce4","after":"407899245d16364c7dffd4506572f2624d000ea1","ref":"refs/heads/main","pushedAt":"2024-05-03T11:41:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Delete experimental code\n\nSummary: This reduces Reverie's maintenance burden going forward. This code isn't used and is in the commit history if it needs to be referenced.\n\nReviewed By: VladimirMakaev\n\nDifferential Revision: D56889383\n\nfbshipit-source-id: 6fe2ca3a945a69a84624f545102283bda0285233","shortMessageHtmlLink":"Delete experimental code"}},{"before":"ef50616df93adcec15af9e0563dcc4b78240c596","after":"374247cc0af2b866ea87d449b0a014df46f54ce4","ref":"refs/heads/main","pushedAt":"2024-04-24T16:52:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update tokio: 1.36.0 -> 1.37.0\n\nSummary: Followed the wiki page here: https://www.internalfb.com/intern/wiki/Rust/Third_Party_Libraries/Adding_or_Updating_Libraries/\n\nReviewed By: capickett\n\nDifferential Revision: D56484070\n\nfbshipit-source-id: e1ed52d58f7db8ad32ce67b67df2e83a567db123","shortMessageHtmlLink":"Update tokio: 1.36.0 -> 1.37.0"}},{"before":"d296065b477378cf17d503f1c5430ce235122f30","after":"ef50616df93adcec15af9e0563dcc4b78240c596","ref":"refs/heads/main","pushedAt":"2024-04-23T21:47:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"ffi_returns_twice is removed\n\nSummary: forward compat fix: feature ffi_returns_twice is removed in 1.78.0.\n\nReviewed By: dtolnay\n\nDifferential Revision: D56452209\n\nfbshipit-source-id: f5d9f9dbd63c1213ef71d023f08e97a793f9e525","shortMessageHtmlLink":"ffi_returns_twice is removed"}},{"before":"9a1320bb464cc1884d2d53c4b8208eac31b33871","after":"d296065b477378cf17d503f1c5430ce235122f30","ref":"refs/heads/main","pushedAt":"2024-04-18T19:16:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Bump SKID_MARGIN_RCBS from 60 to 70\n\nSummary:\nFor AMD hosts I'm seeing issues with trying to run `mkfs.ext3` at large sizes using Antlir. We can raise it slightly to deal with this issue.\n\nIf it becomes too much of a problem for Intel hosts, we can always break out compilation for the two processor types\n\nReviewed By: jasonwhite\n\nDifferential Revision: D56271985\n\nfbshipit-source-id: 1af3a007363a241cfa1c3e12585d6f837b274d19","shortMessageHtmlLink":"Bump SKID_MARGIN_RCBS from 60 to 70"}},{"before":"1711463ce369c275f7cf7fe1260675f72603661c","after":"9a1320bb464cc1884d2d53c4b8208eac31b33871","ref":"refs/heads/main","pushedAt":"2024-04-06T06:53:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"third-party/rust: Bump bytes 1.1 -> 1.6.0\n\nSummary:\nAs it says on the tin. There have been many new features added since the old version. [Staring at the changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md), I don't believe they added breaking changes.\n\nChanges to other libraries:\n- *common/rust/folly/iobuf* - the panic message changed so I changed the should_panic rule to match\n\nReviewed By: diliop\n\nDifferential Revision: D55807882\n\nfbshipit-source-id: 8d70a8bae57509fdca82ab18770275111a1f1902","shortMessageHtmlLink":"third-party/rust: Bump bytes 1.1 -> 1.6.0"}},{"before":"b5ec95a82c0f9a9c0533b2510d6c36825d0bc784","after":"1711463ce369c275f7cf7fe1260675f72603661c","ref":"refs/heads/main","pushedAt":"2024-03-27T23:27:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"rust/third-party: update to futures-0.3.30\n\nSummary:\nChangelog since last import:\n\n```\n# 0.3.30 - 2023-12-24\n\n* Add `{BiLock,SplitStream,SplitSink,ReadHalf,WriteHalf}::is_pair_of` (#2797)\n* Fix panic in `FuturesUnordered::clear` (#2809)\n* Fix panic in `AsyncBufReadExt::fill_buf` (#2801, #2812)\n* Improve support for targets without atomic CAS (#2811)\n* Remove build scripts (#2811)\n\n# 0.3.29 - 2023-10-26\n\n* Add `TryStreamExt::try_ready_chunks` (#2757)\n* Add `TryStreamExt::{try_all,try_any}` (#2783)\n* Add `UnboundedSender::{len,is_empty}` (#2750)\n* Fix `Sync` impl of `FuturesUnordered` (#2788)\n* Fix infinite loop caused by invalid UTF-8 bytes (#2785)\n* Fix build error with -Z minimal-versions (#2761)\n```\n\nI'm updating this as I need `TryStreamExt::try_all()` for a Sandcastle Worker change.\n\nReviewed By: krallin\n\nDifferential Revision: D55318002\n\nfbshipit-source-id: 0f64b13570cd1644000c3639bf16c0746266cb8e","shortMessageHtmlLink":"rust/third-party: update to futures-0.3.30"}},{"before":"91b8ebf0b6d194d14ebfa424de161bc706c84dd5","after":"b5ec95a82c0f9a9c0533b2510d6c36825d0bc784","ref":"refs/heads/main","pushedAt":"2024-03-26T04:46:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"third-party/rust: make tracing and tracing-subscriber available to no-std universe\n\nSummary: They support no-std with a bunch of features turned off.\n\nReviewed By: dtolnay\n\nDifferential Revision: D55333115\n\nfbshipit-source-id: e66ee699cb3bc3e74f6c7b4d9a81e488e9768e40","shortMessageHtmlLink":"third-party/rust: make tracing and tracing-subscriber available to no…"}},{"before":"29ce9faab8aeb6bb7e0dff60d9276cfcd8efd45e","after":"91b8ebf0b6d194d14ebfa424de161bc706c84dd5","ref":"refs/heads/main","pushedAt":"2024-03-19T00:03:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Upgrade tokio\n\nSummary:\nNeed to add some third-party, which is pulling newer tokio.\n\nLand upgrade separately for visibility and for easier bisect and revert.\n\nReviewed By: Imxset21, JakobDegen\n\nDifferential Revision: D55030643\n\nfbshipit-source-id: 47b509ce2103d1dd64c66aa250133eb25758a750","shortMessageHtmlLink":"Upgrade tokio"}},{"before":"8298a777ca3d3a93e1c06bea6667e3fd198ea7df","after":"29ce9faab8aeb6bb7e0dff60d9276cfcd8efd45e","ref":"refs/heads/main","pushedAt":"2024-03-07T20:48:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updated timer to add my processor (#31)\n\nSummary:\nA quick fix for https://github.com/facebookexperimental/reverie/issues/30. Have not verified timer functionality, but this prevents a crash.\n\nPull Request resolved: https://github.com/facebookexperimental/reverie/pull/31\n\nReviewed By: VladimirMakaev\n\nDifferential Revision: D54647876\n\nPulled By: jasonwhite\n\nfbshipit-source-id: e1b1f110e64f5a78589d0b165cb93578efbe3e66","shortMessageHtmlLink":"Updated timer to add my processor (#31)"}},{"before":"4bf3d8d0905e1b78dafa4067e2913ff5a267bbf9","after":"8298a777ca3d3a93e1c06bea6667e3fd198ea7df","ref":"refs/heads/main","pushedAt":"2024-02-22T17:19:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"bitflags: enable feature 'serde'\n\nSummary:\nbuilding the \"renderdag\" package (fbcode/eden/scm/lib/renderdag/Cargo.toml) fails with\n```lang=php,counterexample\nerror[E0277]: the trait bound `InternalBitFlags: Serialize` is not satisfied\n --> /data/users/shaynefletcher/fbsource/fbcode/eden/scm/lib/renderdag/src/render.rs:213:46\n```\nthis diff resolves the issue by enabling the `serde` feature on the bitflags crate\n\nReviewed By: capickett\n\nDifferential Revision: D54067851\n\nfbshipit-source-id: 2f6ababbae0c4667e4896f03a2fb39c973de535c","shortMessageHtmlLink":"bitflags: enable feature 'serde'"}},{"before":"d3e069f0bbdf029ff54d7bc28fb27278cb1a67e1","after":"4bf3d8d0905e1b78dafa4067e2913ff5a267bbf9","ref":"refs/heads/main","pushedAt":"2024-02-20T18:36:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update platform010 & platform010-aarch64 symlinks\n\nSummary:\n`1.76.0` release with fixes addressing the following:\n* Release notes ([link](https://releases.rs/docs/1.76.0/))\n * Most notable is [#118054](https://github.com/rust-lang/rust/pull/118054/) manifesting as:\n```\nerror: unused implementer of `futures::Future` that must be used\n --> fbcode/mlx/metalearner/housekeeper/housekeeper.rs:213:13\n |\n213 | self.ping_oncall(&oncall, usecases);\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n |\n = note: futures do nothing unless you `.await` or poll them\n = note: requested on the command line with `-D unused-must-use`\n```\n* Changes in `search_index.js` spec for `rustdoc` ([link](https://github.com/rust-lang/rust/pull/118910/files#diff-3ac57789ddcd2856a3b4f0c444f2813315179bdbe55bb945fe64fcb27b53fee5L491))\n* Split of `#![feature(exposed_provenance)]` ([link](https://github.com/rust-lang/rust/pull/118487)) from [#95228](https://github.com/rust-lang/rust/issues/95228)\n* `buck2` OSS toolchain bump to `nightly-2023-12-11` just before [#11878](https://github.com/rust-lang/rust-clippy/pull/11878) and a bunch of other clippy lint renames.\n\nReviewed By: dtolnay\n\nDifferential Revision: D53776867\n\nfbshipit-source-id: 78db83d8cdd6b0abae2b94ed1075e67b501fcd73","shortMessageHtmlLink":"Update platform010 & platform010-aarch64 symlinks"}},{"before":"9f52ff612665299f1ae6502cd1d3cc871ad136c0","after":"d3e069f0bbdf029ff54d7bc28fb27278cb1a67e1","ref":"refs/heads/main","pushedAt":"2024-02-15T18:37:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add AMD Zen 2 Matisse support (#28)\n\nSummary:\nChecked the AMD PPR and confirmed the event encoding\n\n\"image\"\n\nPull Request resolved: https://github.com/facebookexperimental/reverie/pull/28\n\nReviewed By: asm89\n\nDifferential Revision: D53796098\n\nPulled By: jasonwhite\n\nfbshipit-source-id: 9d7e8f29c5b7307819735034decfd2deba60ca3a","shortMessageHtmlLink":"Add AMD Zen 2 Matisse support (#28)"}},{"before":"17e8f64e9467d84cfb32f964d0ca7fc72e2ec194","after":"9f52ff612665299f1ae6502cd1d3cc871ad136c0","ref":"refs/heads/main","pushedAt":"2024-02-15T18:15:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"ci: Make clippy less strict (#29)\n\nSummary:\nThe clippy errors with `clippy::all` aren't too helpful. Plus, with building on nightly, new lints often break CI.\n\nPull Request resolved: https://github.com/facebookexperimental/reverie/pull/29\n\nReviewed By: asm89\n\nDifferential Revision: D53796464\n\nPulled By: jasonwhite\n\nfbshipit-source-id: d90323da824a97976c62f46c72aa7c611d31e359","shortMessageHtmlLink":"ci: Make clippy less strict (#29)"}},{"before":"0daba07586cf4d8cc1b36149b16dbbd654c98ce6","after":"98cdc95973c03d00e0a9a9a2a5a361ae489e3db0","ref":"refs/heads/jw/fix-clippy","pushedAt":"2024-02-15T05:53:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jasonwhite","name":"Jason White","path":"/jasonwhite","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/865541?s=80&v=4"},"commit":{"message":"ci: Make clippy less strict","shortMessageHtmlLink":"ci: Make clippy less strict"}},{"before":"06f05e10f44a1928ce48f8cd528e9434d3238c0c","after":"17e8f64e9467d84cfb32f964d0ca7fc72e2ec194","ref":"refs/heads/main","pushedAt":"2024-02-09T04:09:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix broken test after toolchain update\n\nSummary: These tests did unaligned reads/writes, which can produce a `SIGABRT` instead of a `SIGSEGV`. Simply align the reads/writes to 8 bytes to fix the tests.\n\nReviewed By: JakobDegen, dtolnay\n\nDifferential Revision: D53597637\n\nfbshipit-source-id: e2ede420b6249223569af6d89d43a47438967ced","shortMessageHtmlLink":"Fix broken test after toolchain update"}},{"before":"b102b3bf4950605771a58be5f0cd54edc112e27d","after":"06f05e10f44a1928ce48f8cd528e9434d3238c0c","ref":"refs/heads/main","pushedAt":"2024-01-25T15:06:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rustfix codemod\n\nSummary:\nApply fixes from `./common/rust/tools/rustfix2/scripts/rustfix_codemod`\n\nThen check any remaining lints highlighted and adjust code to correct them.\n\nReviewed By: zertosh\n\nDifferential Revision: D52975050\n\nfbshipit-source-id: b52d4d84557c78110543d250a40173208fca17ca","shortMessageHtmlLink":"Rustfix codemod"}},{"before":"d7d1e7eec6fb70b11f870e5ef2a73758a71d7beb","after":"b102b3bf4950605771a58be5f0cd54edc112e27d","ref":"refs/heads/main","pushedAt":"2024-01-17T12:39:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add support for Intel Icelake architecture\n\nReviewed By: jasonwhite\n\nDifferential Revision: D52832812\n\nfbshipit-source-id: 6e388a179aea39cfb21197d895fbf5b14a1123b7","shortMessageHtmlLink":"Add support for Intel Icelake architecture"}},{"before":"b1516c3941ecc544b92fae23e11e59ea07932eb0","after":"d7d1e7eec6fb70b11f870e5ef2a73758a71d7beb","ref":"refs/heads/main","pushedAt":"2024-01-16T15:40:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"reverie-syscalls: Fix broken OSS CI\n\nSummary:\nMy recent diff: D49742979 which upgraded `bitflags` to 2.4 seems to have broken the Open Source CI for a few crates under `hermetic_infra`.\n\nThat is because among other changes, `bitflags` 2.x requires the `serde` Cargo feature to `#[derive(Serialize, Deserialize)]` on generated flag types.\n\nSee [the release notes](https://github.com/bitflags/bitflags/releases/tag/2.0.0?fbclid=IwAR0BHMz6T_jmIkXaJmkdvc9LdDTW15G5SSU_A-cZvLxof0aGS0BA7Hqnme0)\n\nThis change should fix it.\n\nReviewed By: mitrandir77\n\nDifferential Revision: D52801745\n\nfbshipit-source-id: 826c70e5a111ab1a1159cceab6fb40831f355287","shortMessageHtmlLink":"reverie-syscalls: Fix broken OSS CI"}},{"before":"d3daaebfe17a4e8eb79793fe7789dab6b85dc548","after":"b1516c3941ecc544b92fae23e11e59ea07932eb0","ref":"refs/heads/main","pushedAt":"2024-01-16T08:41:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update bitflags to 2.4\n\nSummary:\n## Motivation\n\nSince the latest compiler update, we are getting `clippy::bad_bit_mask` errors at the callsites of `bitflags!` macros where one of the variant is zero.\n[Upstream won't address it in the `1.x` branch](https://github.com/bitflags/bitflags/pull/373) and recommends upgrading to the `2.x` branch.\n\nWe are very close to reaching **zero clippy lints** in [Mononoke and other servers](https://fburl.com/code/pd76yn5e), which would feel nice.\n\n## Specific categories of changes (in case it helps with the code review)\n\nThe change from `1.x` to `2.x` introduces a number of backward compatibility breakages which I had to workaround in our codebase.\nSee [the release notes for 2.0](https://github.com/bitflags/bitflags/releases/tag/2.0.0) for the explanation for the manual fixes I had to perform at each call site.\n ---\n**Adding traits to derive:**\n```\n#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Debug, Clone, Copy)]\n```\n> Generated flags types now derive fewer traits. If you need to maintain backwards compatibility, you can derive the following yourself:\n ---\n**Replacing read uses of `.bits` with `.bits()`**\n> You can now use the .bits() method instead of the old .bits.\n> The representation of generated flags types has changed from a struct with the single field bits to a newtype.\n ---\n**Replacing raw setting of `.bits` with `.from_bits_retain()`**\nDue to the point above, the representation of the type is not exposed anymore. From [the documentation](https://docs.rs/bitflags/latest/bitflags/example_generated/struct.Flags.html#method.from_bits_retain), `from_bits_retain` \"convert from a bits value exactly\", which matches the old behaviour\n ---\n**Replacing the unsafe `from_bits_unchecked` method with `from_bits_retain`**\n> The unsafe from_bits_unchecked method is now a safe from_bits_retain method.\n ---\n**Extracting some structs outside of the `bitflags!` macro**\nApart from the derives that `bitflags` knows about, such as `serde`, `bitflags` now can't deal with custom derives in macros with the previous syntax. I followed the recommendation from [their documentation](https://docs.rs/bitflags/latest/bitflags/index.html#custom-derives) to declare the `struct` ahead of of the macro call and only declare the `impl` block inside the macro.\n ---\n**Changes to test output**\nThis does not stand out in the release notes, but as of [this upstream PR](https://github.com/bitflags/bitflags/pull/297), the `Debug` output of generated bitflags has changed. This means any tests that rely on this (and of course, there are a few) needed updating.\nIn particular, the `vespa` tests rely on that output in a non-obvious way. You might have to trust me (and CI) on these ones...\n\nReviewed By: dtolnay\n\nDifferential Revision: D49742979\n\nfbshipit-source-id: c818c37af45f0964e8fdb7ec6173ad66bb982c00","shortMessageHtmlLink":"Update bitflags to 2.4"}},{"before":"00a4d01ee2e66533cac597eef7b0a5387e3374a5","after":"d3daaebfe17a4e8eb79793fe7789dab6b85dc548","ref":"refs/heads/main","pushedAt":"2024-01-10T07:02:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"format_code_in_doc_comments = true\n\nSummary:\nAnother attempt to enable the option.\n\n[We agreed](https://fb.workplace.com/groups/rust.language/posts/24184800024475285) we want it everywhere by default.\n\n# Help us, help yourself\n\nIf you can help enabling this option, consider running this command ahead of time:\n\n```\nhg files . -I 'your_project/**/*.rs' | \\\n xargs arc rustfmt --config format_code_in_doc_comments=true\n```\n\nFix the which is not landed yet:\n\n```\nhg st --rev .~1 -n -ma -I '**/*.rs' | \\\n xargs arc rustfmt --config format_code_in_doc_comments=true\n```\n\nFix the stack of commits: checkout the top commit, and then:\n```\n# must include changes from D52632478\nfbcode/scripts/nga/stack-rustfmt-new\n```\n\n# Previous attempt\n\nD42766542\n\nReviewed By: zertosh, dtolnay\n\nDifferential Revision: D52632085\n\nfbshipit-source-id: f45998c76076470d66339eb99f585856d2114999","shortMessageHtmlLink":"format_code_in_doc_comments = true"}},{"before":"9a92f2f4e90f6059e5ec0b5374a336b54cb3f5d1","after":"00a4d01ee2e66533cac597eef7b0a5387e3374a5","ref":"refs/heads/main","pushedAt":"2024-01-10T00:58:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"format_code_in_doc_comments = true\n\nSummary: D52632085\n\nReviewed By: zertosh\n\nDifferential Revision: D52640376\n\nfbshipit-source-id: da918401a991b1f15dd84e1e9066cca1457afd28","shortMessageHtmlLink":"format_code_in_doc_comments = true"}},{"before":"9ce4ac6e2b96d5f89aaa6a4e0a9713b9c3c26183","after":"9a92f2f4e90f6059e5ec0b5374a336b54cb3f5d1","ref":"refs/heads/main","pushedAt":"2024-01-02T23:34:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"colored 1.9 -> 2.1.0\n\nSummary: A newer version of colored adds support for true color terminal text coloring. The changelog only indicates \"Alter Color interface to return Cow<'static, str>\" besides the true color support as a \"change\" in the changelog and I'm not expecting people to really use this. If they do, I'll see it in Sandcastle?\n\nReviewed By: dtolnay\n\nDifferential Revision: D52391497\n\nfbshipit-source-id: c08fffc171f7d5f9b75f96617aa673867ab45312","shortMessageHtmlLink":"colored 1.9 -> 2.1.0"}},{"before":"7d08fc8085d9b0d594b0f317fba5106d404f07e8","after":"9ce4ac6e2b96d5f89aaa6a4e0a9713b9c3c26183","ref":"refs/heads/main","pushedAt":"2023-12-11T23:52:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add default crate information\n\nSummary: Adds basic info that every crate should have.\n\nReviewed By: dtolnay\n\nDifferential Revision: D52051107\n\nfbshipit-source-id: 828ac6a752dbb4b419577fca08815014c8b96c42","shortMessageHtmlLink":"Add default crate information"}},{"before":"b5d1131efc1e14b93900cc3ec2ee1839088a5fa4","after":"7d08fc8085d9b0d594b0f317fba5106d404f07e8","ref":"refs/heads/main","pushedAt":"2023-12-08T10:25:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Upgrade heapless 0.7.15 -> 0.8.0\n\nSummary: Sync with fw-rust.\n\nReviewed By: zertosh\n\nDifferential Revision: D51963086\n\nfbshipit-source-id: 22021abffef9d8815f98b0c6fc3c9d4e3971331f","shortMessageHtmlLink":"Upgrade heapless 0.7.15 -> 0.8.0"}},{"before":"ccaa2e5f1d6148118add1c38fe98fc652ded716f","after":"b5d1131efc1e14b93900cc3ec2ee1839088a5fa4","ref":"refs/heads/main","pushedAt":"2023-12-04T21:23:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update gimli from 0.26.1 to 0.28.1\n\nSummary:\nThis release includes https://github.com/gimli-rs/addr2line/pull/260 which unblocks supporting Split DWARF in reverie and cadaverdog.\n\nSeparately, ayermolo is looking into whether this gimli update fixes an issue with an iOS test that uses lionhead, and uses gimli to dump debuginfo, which is blocking the land of DWARF5.\n\nReviewed By: jasonwhite\n\nDifferential Revision: D51814926\n\nfbshipit-source-id: ae0882432019250060c65792476a0f6e296daffb","shortMessageHtmlLink":"Update gimli from 0.26.1 to 0.28.1"}},{"before":"d22b5fa9deccf35b6591930e27af8d28016d001c","after":"ccaa2e5f1d6148118add1c38fe98fc652ded716f","ref":"refs/heads/main","pushedAt":"2023-12-02T21:56:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"update platform010 & platform010-aarch64 symlinks\n\nSummary:\nRelease notes: https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html\n\nThis release is coupled with an update of the `anyhow` and `thiserror` crates because the unstable standard library API for backtraces has changed.\n\nFbcode changes:\n\n- `feature(default_free_fn)` deleted (D50300881)\n- `noop_method_call` lint becomes warn-by-default (D50486032, D50516201)\n- stronger `invalid_reference_casting` detection (D50488164)\n- `feature(unix_chown)` has been stabilized\n- `feature(provide_any)` and `std::provider` deleted\n- `clippy::unwrap_or_else_default` renamed to `clippy::unwrap_or_default`\n- type inference ambiguities (D51780425)\n- `nu-command` build error (D51779062)\n\nReviewed By: AndreasBackx, shayne-fletcher\n\nDifferential Revision: D50294321\n\nfbshipit-source-id: 0fac87f6ba072ad029f9ce41ce94ed813e855b20","shortMessageHtmlLink":"update platform010 & platform010-aarch64 symlinks"}},{"before":"d744c1f65ba0911fd59732e65eec2f186f38be62","after":"d22b5fa9deccf35b6591930e27af8d28016d001c","ref":"refs/heads/main","pushedAt":"2023-11-30T02:39:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update autocargo component on FBS:master\n\nReviewed By: dtolnay\n\nDifferential Revision: D51692353\n\nfbshipit-source-id: 44864a348711875983de81758bbe05b46ad4c604","shortMessageHtmlLink":"Update autocargo component on FBS:master"}},{"before":"3db2bda0626a44f5d780ac782df017ea9d95b6e5","after":"d744c1f65ba0911fd59732e65eec2f186f38be62","ref":"refs/heads/main","pushedAt":"2023-11-28T23:56:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update proc-macro2 to 1.0.70\n\nSummary:\nThis release includes a fix to `proc_macro2::Ident::new` to report invalid input at the call site using #[track_caller], instead of inside proc-macro2 code.\n\nThis affects LLVM staging (which is LLVM 18) because old bindgen (<0.62.0) is incompatible with Clang 16+, manifesting as panicks in `Ident::new`. See {D40685340}.\n\n**Before:**\n\n```\nAction failed: fbsource//third-party/rust:loopdev-0.4.0-build-script-run (buildscript)\nthread 'main' panicked at '\"enum_(unnamed_at_/usr/include/linux/loop_h_21_1)\" is not a valid Ident', third-party/rust/vendor/proc-macro2-1.0.69/src/fallback.rs:817:9\n\nAction failed: fbsource//third-party/rust:virt-sys-0.1.0-build-script-run (buildscript)\nthread 'main' panicked at '\"_virTypedParameter_union_(unnamed_at___/__/__/__/__/__/fbcode/ca3f1b68f56b9220/third-party-buck/platform010/build/libvirt/__include__/include/include/libvirt/libvirt-common_h_206_5)\" is not a valid Ident', third-party/rust/vendor/proc-macro2-1.0.69/src/fallback.rs:817:9\n```\n\n**After:**\n\n```\nAction failed: fbsource//third-party/rust:loopdev-0.4.0-build-script-run (buildscript)\nthread 'main' panicked at '\"enum_(unnamed_at_/usr/include/linux/loop_h_21_1)\" is not a valid Ident', third-party/rust/vendor/bindgen-0.59.2/src/ir/context.rs:878:9\n\nAction failed: fbsource//third-party/rust:virt-sys-0.1.0-build-script-run (buildscript)\nthread 'main' panicked at '\"_virTypedParameter_union_(unnamed_at___/__/__/__/__/__/fbcode/ca3f1b68f56b9220/third-party-buck/platform010/build/libvirt/__include__/include/include/libvirt/libvirt-common_h_206_5)\" is not a valid Ident', third-party/rust/vendor/bindgen-0.59.2/src/ir/context.rs:878:9\n```\n\nOf course, that panic still needs to be fixed properly. I will pursue that next. But at least the location of the faulty code is reported correctly.\n\nReviewed By: zertosh\n\nDifferential Revision: D51633230\n\nfbshipit-source-id: db9794ed4ea70f773925bdaf9a11de289d2aa25c","shortMessageHtmlLink":"Update proc-macro2 to 1.0.70"}},{"before":"f4c1e43b134972b8517078b7db4bcec42052b43b","after":null,"ref":"refs/heads/fixup-T170770291-main","pushedAt":"2023-11-22T15:54:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bigfootjon","name":"Jon Janzen","path":"/bigfootjon","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6403568?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQN7cUwA","startCursor":null,"endCursor":null}},"title":"Activity · facebookexperimental/reverie"}