{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":22231878,"defaultBranch":"main","name":"wdt","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-07-24T21:23:34.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1646434559.7757812","currentOid":""},"activityList":{"items":[{"before":"d94b2d5df6f1c803f9f3b8ed9247b752fa853865","after":"6263fee3bebc8bb0012e095723170f70b99ff67d","ref":"refs/heads/main","pushedAt":"2024-05-21T19:41:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused function from wdt/util/EncryptionUtils.cpp\n\nSummary:\n`-Wunused-function` has identified an unused function. This diff removes it. In many cases these functions have existed for years in an unused state.\n\nThis diff may also be removing code related to antiquated usage of OpenSSL 1.1.0.\n\nReviewed By: palmje\n\nDifferential Revision: D57577747\n\nfbshipit-source-id: b04ed4b0e7db83fa2dc13215408687cbd056fa4f","shortMessageHtmlLink":"Remove unused function from wdt/util/EncryptionUtils.cpp"}},{"before":"f0c332447174ae5ca22b02ee07eded32c6b0599a","after":"d94b2d5df6f1c803f9f3b8ed9247b752fa853865","ref":"refs/heads/main","pushedAt":"2024-02-05T16:16:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"migrate from nested-name ReadHolder (assorted)\n\nSummary:\nX-link: https://github.com/facebookincubator/velox/pull/8659\n\nMigrate from nested-name `{mutex}::ReadHolder` to `std::shared_lock`.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D53288412\n\nfbshipit-source-id: 138a18835a0bb62d4de0beddab2eed084847b68d","shortMessageHtmlLink":"migrate from nested-name ReadHolder (assorted)"}},{"before":"fc1850903c8b4f2fd9d5c5ef9b0d7263c0c0af5f","after":"f0c332447174ae5ca22b02ee07eded32c6b0599a","ref":"refs/heads/main","pushedAt":"2024-01-16T03:25:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in wdt/util/ClientSocket.cpp\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D52582859\n\nfbshipit-source-id: 60747cd86d48b70d4ebbe154bf1fb789cc51710e","shortMessageHtmlLink":"Fix shadowed variable in wdt/util/ClientSocket.cpp"}},{"before":"66f17af009ef6eaf2707bb8bb511ba6bcf3d9bbe","after":"fc1850903c8b4f2fd9d5c5ef9b0d7263c0c0af5f","ref":"refs/heads/main","pushedAt":"2024-01-12T06:04:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"migrate from nested-name WriteHolder\n\nSummary: Migrate from nested-name `{mutex}::WriteHolder` to `std::unique_lock`.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52514822\n\nfbshipit-source-id: a5c23d5cbe968a64f14a7e8155d2af2afdb4a68b","shortMessageHtmlLink":"migrate from nested-name WriteHolder"}},{"before":"3b52ef573129fb799319630bd438717761111f57","after":"66f17af009ef6eaf2707bb8bb511ba6bcf3d9bbe","ref":"refs/heads/main","pushedAt":"2023-12-02T02:57:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused exception parameter from warm_storage/security/token_provider/BearerMiniTokenVerifier.cpp\n\nSummary:\n`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.\n\nThis:\n```\ntry {\n ...\n} catch (exception& e) {\n // no use of e\n}\n```\nshould instead be written as\n```\n} catch (exception&) {\n```\n\nIf the code compiles, this is safe to land.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D51775546\n\nfbshipit-source-id: 288a30056f11fe88ce6c933f8d4b6a8a94cf743d","shortMessageHtmlLink":"Remove unused exception parameter from warm_storage/security/token_pr…"}},{"before":"6a122f24deb4f2ff6c6f97b6a803301a7f7b666c","after":"3b52ef573129fb799319630bd438717761111f57","ref":"refs/heads/main","pushedAt":"2023-07-11T19:19:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"wdt: fix opensource build with latest folly\n\nSummary:\nThanks to alainpleno for proposing this fix.\n\nFixes: https://github.com/facebook/wdt/issues/233\n\nReviewed By: michel-slm\n\nDifferential Revision: D47372081\n\nfbshipit-source-id: 5c1010a27cac1202166eb938617de94682dc68f9","shortMessageHtmlLink":"wdt: fix opensource build with latest folly"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUDoCEwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/wdt"}