{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":58146669,"defaultBranch":"main","name":"sapling","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-05-05T16:53:47.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714584961.0","currentOid":""},"activityList":{"items":[{"before":"310477e5b92d0c664e9fb9f7281ee6277175fa3e","after":"7da17e6ba8729ac3a51780f64e89429eedf31569","ref":"refs/heads/main","pushedAt":"2024-05-25T16:39:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/0f14d88c8e36ef018c2d2c17e46cab250cd7c1ba\nhttps://github.com/facebook/fb303/commit/c1301b3ef8622f37e3e950da60ba509cb935a5d9\nhttps://github.com/facebook/fbthrift/commit/96486e0316c28d5e90c16b4eebd8b890bdc52f59\nhttps://github.com/facebook/folly/commit/945a193fcd15edaf83956bfad2f6a9a149fda6bb\nhttps://github.com/facebook/mvfst/commit/e839fd69fed6116865d477f8b0d8cfaf2ac39b5d\nhttps://github.com/facebook/proxygen/commit/d2702f976a07de0803d0e90127e814480de67dda\nhttps://github.com/facebook/wangle/commit/76ea509f967d3e90817855e521a58c02d454673d\nhttps://github.com/facebookexperimental/edencommon/commit/8da71a573c5ceb0d8c79bf976996b68fd31c0e1d\nhttps://github.com/facebookexperimental/rust-shed/commit/c849bc0d2c374e801f7532d99bb95a224d6f0f25\nhttps://github.com/facebookincubator/fizz/commit/ad8f457fad9bb89b1f5543d7513c7ff37f7f76d0\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 6791e4485dd84c702c1755f98293b43198953ae9","shortMessageHtmlLink":"Updating submodules"}},{"before":"c65179bd1d2c2e16119b3580593f02519eeeb280","after":"310477e5b92d0c664e9fb9f7281ee6277175fa3e","ref":"refs/heads/main","pushedAt":"2024-05-25T05:49:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add tests for fetch sloc\n\nSummary: tsia\n\nReviewed By: quark-zju\n\nDifferential Revision: D57795331\n\nfbshipit-source-id: 263f1e457bd0569e09b39beecd9d667ab4e2179e","shortMessageHtmlLink":"add tests for fetch sloc"}},{"before":"8859530286f411a9d84869b544088a9225a25c11","after":"c65179bd1d2c2e16119b3580593f02519eeeb280","ref":"refs/heads/main","pushedAt":"2024-05-24T20:33:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rename two functions in SaplingBackingStore\n\nSummary:\n### What is renaming in this diff\n`getBlobImpl()`  --> `getBlobEnqueue()`\n`getBlobMetadataImpl()` --> `getBlobMetadataEnqueue()`\n\n### why?\nThese two functions do not get Blob or BlobMetadata from Sapling directly. They enqueue the requests into `SaplingImportRequestQueue`, and later in the process functions the requests will dequeue and run to get object from Sapling. Postfixing their names with Enquue will show what they are doing better, and makes the code reading easier.\nAlso, it is more consistent with `getTree`. Because `getTree` will call `getTreeEnqueue` not `getTreeImpl`\n\nReviewed By: genevievehelsel\n\nDifferential Revision: D57705533\n\nfbshipit-source-id: 3d7eb38ef47b12187ea676ec8bb068205f8ea00b","shortMessageHtmlLink":"Rename two functions in SaplingBackingStore"}},{"before":"50eb7a2ac786e94645944b86e89b57f8b1404f91","after":"8859530286f411a9d84869b544088a9225a25c11","ref":"refs/heads/main","pushedAt":"2024-05-24T16:35:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/39dbb88bf5a0a3243f4a4e55e555780206cb4125\nhttps://github.com/facebook/fb303/commit/a828824cdbb84e354f90bcaa67b02ad1f2c25e9d\nhttps://github.com/facebook/fbthrift/commit/10a129cfa15ccdc6e9136a40945c1f12446bb1c0\nhttps://github.com/facebook/folly/commit/3a8a307cd0ff054b8c8ef4dbbb9c86b31873fdb0\nhttps://github.com/facebook/mvfst/commit/a6950e85dee2b06670ed0cf50b91798b7e2ce5b9\nhttps://github.com/facebook/proxygen/commit/7865621bc018a57b7625f98e1cd40b0390a05059\nhttps://github.com/facebook/wangle/commit/5981297b7be698d096f5eb85b3c1cc76e1dad55e\nhttps://github.com/facebookexperimental/edencommon/commit/13aeaf68ee75a4371813808a99d516c472bb56aa\nhttps://github.com/facebookexperimental/rust-shed/commit/a14d60d886e6f0915c3353b53db91e5bd334c5f8\nhttps://github.com/facebookincubator/fizz/commit/430eade366669dc800387db32f994fb717c846b5\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: f8d09968bb0d91f0704b568476670906da945a4b","shortMessageHtmlLink":"Updating submodules"}},{"before":"0a8a8e9640be69e8c391e48642c6d1bd91cdda63","after":"50eb7a2ac786e94645944b86e89b57f8b1404f91","ref":"refs/heads/main","pushedAt":"2024-05-24T15:09:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make sure all the repos are instantiated with submodules for verification binaries\n\nSummary:\nnote: this is long overdue submodule-verification stack head\n\nThis diff makes two binaries that use working copy verification instantiate submodule deps so we can actually do validation.\n\nDifferential Revision: D57217633\n\nfbshipit-source-id: d404c0e792c844464092297a099f8ebcc4f9ae02","shortMessageHtmlLink":"make sure all the repos are instantiated with submodules for verifica…"}},{"before":"4335593999d10ac0315c2d062ff379c027ffef72","after":"0a8a8e9640be69e8c391e48642c6d1bd91cdda63","ref":"refs/heads/main","pushedAt":"2024-05-24T13:16:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim atomic_read_mostly_main_ptr in eden\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental:atomic_read_mostly_main_ptr -> //folly/concurrency/memory:atomic_read_mostly_main_ptr\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/AtomicReadMostlyMainPtr.h -> folly/concurrency/memory/AtomicReadMostlyMainPtr.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: kmancini\n\nDifferential Revision: D57681718\n\nfbshipit-source-id: 2ce6927a52b5832097a97bde03202dcd9fb13520","shortMessageHtmlLink":"Deshim atomic_read_mostly_main_ptr in eden"}},{"before":"20db1636aa9c0ca1b82e1bac3b4e5f1ee6349fe8","after":"4335593999d10ac0315c2d062ff379c027ffef72","ref":"refs/heads/main","pushedAt":"2024-05-24T11:03:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"large_to_small validation body\n\nSummary: NOTE: because we always call both sync direction this is *technically* redundant and doesn't change test outputs but... I'd rather have this extra layer of verification.\n\nReviewed By: gustavoavena\n\nDifferential Revision: D57173529\n\nfbshipit-source-id: 4dacb67cd68b5ef157e02e5aeef03cbf04cff7c1","shortMessageHtmlLink":"large_to_small validation body"}},{"before":"84005a595c7d348765817a3a209b788a653acd92","after":"20db1636aa9c0ca1b82e1bac3b4e5f1ee6349fe8","ref":"refs/heads/main","pushedAt":"2024-05-24T03:26:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add --kill to handles\n\nSummary:\nThis diff adds a switch to handles, --kill. If present, it will try to kill processes holding on to handles to the mount point or its children.\n\nPossibly too verbose,  but we need some on-the-field output for now.\n\nReviewed By: kmancini\n\nDifferential Revision: D57474212\n\nfbshipit-source-id: 9eb7e230d5013d0e05308b761ac844d8d5b104b1","shortMessageHtmlLink":"Add --kill to handles"}},{"before":"f843d23d61f36dc691a2cdd99c0d7a887874d80f","after":"84005a595c7d348765817a3a209b788a653acd92","ref":"refs/heads/main","pushedAt":"2024-05-24T01:13:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"eden: Add handle.exe output parser in Rust\n\nSummary:\nhandle.exe is the tool we use in Windows to find which processes are holding on to resources.\n\nFor the Python part of Eden we have code that uses it, but we don't have an equivalent for Rust, and we need it to kill processes that might prevent redirect fixup to work.\n\nThis diff adds a parser for the output of handle.exe and its tests, but it doesn't yet use it.\n\nReviewed By: kmancini\n\nDifferential Revision: D56842465\n\nfbshipit-source-id: e160b4ab1405729f14e06fa4dbd2d6402cc34495","shortMessageHtmlLink":"eden: Add handle.exe output parser in Rust"}},{"before":"20f6f2b8b2bba92612b3dc803298b4a1046dbb64","after":"027c19d7006fa5435db2b803db2671a53b83e3dd","ref":"refs/heads/gh-pages","pushedAt":"2024-05-24T00:06:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: f843d23d61f36dc691a2cdd99c0d7a887874d80f","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/sapling/commit/f843d23d61f36dc691a2cdd99c0d7a887874d80f/hovercard\" href=\"https://github.com/facebook/sapling/commit/f843d23d61f36dc691a2cdd99c0d7a887874d80f\"><tt>f843d23</tt></a>"}},{"before":"4c75581f69d5473443f033f6ef898ad396023d55","after":"f843d23d61f36dc691a2cdd99c0d7a887874d80f","ref":"refs/heads/main","pushedAt":"2024-05-23T23:25:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"placeholder to add pro-tip for splitting up big diffs, tinkering\n\nSummary:\n# Context\nBig diffs often lead to SEVs, longer review times, land failures and other issues.  This diff is adding a pro tip in ISL right near the submit button to provide a suggestion to the diff author to split the diff before they submit it.\n\n# Product decisions\n1. Use green for the banner color to keep this as a positive indicator, rather than a warning (though we may experiment on this later)\n2. keep the messaging brief and light, with a tooltip to provide more details (SLOC etc)\n3. using a GK to gate this for now as it's still a WIP, the content will likely change, it's all placeholder-y for now.\n4. load the SLOC on demand\n\nReviewed By: evangrayk\n\nDifferential Revision: D57702785\n\nfbshipit-source-id: 75784740aae43381638b8f474de6ca35263b7c61","shortMessageHtmlLink":"placeholder to add pro-tip for splitting up big diffs, tinkering"}},{"before":"605bf963eaee3fb0f19f478257004c697d84c9b5","after":"4c75581f69d5473443f033f6ef898ad396023d55","ref":"refs/heads/main","pushedAt":"2024-05-23T22:15:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"edenapi: relax min-transfer-speed setting for set_bookmark\n\nSummary:\nThis API does not read data from the server. So it should not use the transfer\nspeed limit.\n\nReviewed By: zzl0\n\nDifferential Revision: D57699623\n\nfbshipit-source-id: 921836cf507537027e7109f02296dc0af87bfb6a","shortMessageHtmlLink":"edenapi: relax min-transfer-speed setting for set_bookmark"}},{"before":"4341d33b4c120947e6a3495f396910ca950e6f35","after":"605bf963eaee3fb0f19f478257004c697d84c9b5","ref":"refs/heads/main","pushedAt":"2024-05-23T20:42:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add vm_control crate\n\nSummary:\nThis adds the vm_control crate.\n\nallow-large-files\n\nReviewed By: capickett\n\nDifferential Revision: D57657352\n\nfbshipit-source-id: bc7b7b284e8450d0d48bbf65698626f479b8e186","shortMessageHtmlLink":"Add vm_control crate"}},{"before":"bf640f1bdc367229676636cd413ada9c9e0fa488","after":"4341d33b4c120947e6a3495f396910ca950e6f35","ref":"refs/heads/main","pushedAt":"2024-05-23T18:41:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"verify_and_filter body\n\nSummary:\nThe verify_and_filter body is reponsible for triggering all downstream validations whenever it hits a submodule or its expansion.\n\nThe downstream functions are not implemented now so now all validations will suceed.\n\nReviewed By: gustavoavena\n\nDifferential Revision: D57173526\n\nfbshipit-source-id: a74b6394c573bf320bf2f51de51a3b6d9c858da7","shortMessageHtmlLink":"verify_and_filter body"}},{"before":"039e982d36395d69e2f630eeb1b1b5d867440218","after":"bf640f1bdc367229676636cd413ada9c9e0fa488","ref":"refs/heads/main","pushedAt":"2024-05-23T17:40:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Confirm before committing/amending with unsaved changes\n\nSummary:\nBefore running commit/amend, if you have unsaved changes, ask if you want to save them first. This is a simple reminder with quick actions to save all or continue without saving. It also shows which files are unsaved.\n\nThis will only have an effect in vscode (currently) where we know which files are unsaved.\n\nReviewed By: quark-zju\n\nDifferential Revision: D57683159\n\nfbshipit-source-id: f73c98057974381a17029f43907b75e9b3d0d712","shortMessageHtmlLink":"Confirm before committing/amending with unsaved changes"}},{"before":"7cd846d8d51a6c22f9430f4d68abd8c6859809c0","after":"039e982d36395d69e2f630eeb1b1b5d867440218","ref":"refs/heads/main","pushedAt":"2024-05-23T17:34:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused function from eden/scm/sapling/ext/extlib/traceprofimpl.cpp\n\nSummary:\n`-Wunused-function` has identified an unused function. This diff removes it. In many cases these functions have existed for years in an unused state.\n\nThis diff may also be removing code related to antiquated usage of OpenSSL 1.1.0.\n\nReviewed By: quark-zju\n\nDifferential Revision: D57577772\n\nfbshipit-source-id: 4ac42fd3850f3248062373cd8997a70082df0add","shortMessageHtmlLink":"Remove unused function from eden/scm/sapling/ext/extlib/traceprofimpl…"}},{"before":"a43d3b28cbce2cea5e9fc1836636a62428d0430a","after":"7cd846d8d51a6c22f9430f4d68abd8c6859809c0","ref":"refs/heads/main","pushedAt":"2024-05-23T16:36:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/0bd1642ffbd94f520029ccdbd420758f2959f3a5\nhttps://github.com/facebook/fb303/commit/aa2b58529069919f3787125485880cd8abfec2a3\nhttps://github.com/facebook/fbthrift/commit/7c087b7ad59c01bf90238f6453c7d8831af886b9\nhttps://github.com/facebook/folly/commit/df0d8d95ae7380b38ed40adadb85b2cb0e29599a\nhttps://github.com/facebook/mvfst/commit/24853da2fc387226e050ad13a499356050785fc8\nhttps://github.com/facebook/proxygen/commit/2826f32ad0b036fd61c8c4aa2ab0a93269f79e06\nhttps://github.com/facebook/wangle/commit/917d068f21cbd6d934b88578596cc4d561fe5917\nhttps://github.com/facebookexperimental/edencommon/commit/d1b0145f06b0c1171eb15202974d45344a316a3b\nhttps://github.com/facebookexperimental/rust-shed/commit/bba4102c36912cedf50d9c9c7e20a327a3d04512\nhttps://github.com/facebookincubator/fizz/commit/e4482e90de4d03a5100ce9163bd057daf16f64f3\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: fc832196e1fd0c93ca35b73853e8c9d1e9721bc8","shortMessageHtmlLink":"Updating submodules"}},{"before":"58efe8d2b2ac951466d69f7bd2933c850866338f","after":"a43d3b28cbce2cea5e9fc1836636a62428d0430a","ref":"refs/heads/main","pushedAt":"2024-05-23T14:22:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"history_traversal: yield periodically to avoid long polls\n\nSummary:\nMutable blame computation for paths with many mutable renames in repos with complicated graphs can take a long time to happen.   If the commit graph is in-memory or well cached, this can hog the tokio thread.\n\nWorkaround this by periodically yielding when computing this information.\n\nReviewed By: YousefSalama\n\nDifferential Revision: D57723764\n\nfbshipit-source-id: b7da9c86061b110de050904d768c777cb4c9f3a4","shortMessageHtmlLink":"history_traversal: yield periodically to avoid long polls"}},{"before":"6c567bf8accc18e3ce9921d1d6f237c9a3a103c5","after":"20f6f2b8b2bba92612b3dc803298b4a1046dbb64","ref":"refs/heads/gh-pages","pushedAt":"2024-05-23T00:05:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 58efe8d2b2ac951466d69f7bd2933c850866338f","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/sapling/commit/58efe8d2b2ac951466d69f7bd2933c850866338f/hovercard\" href=\"https://github.com/facebook/sapling/commit/58efe8d2b2ac951466d69f7bd2933c850866338f\"><tt>58efe8d</tt></a>"}},{"before":"bf9b93b5f97a0ae1cc4bfdbbe63f88f28915c1d5","after":"58efe8d2b2ac951466d69f7bd2933c850866338f","ref":"refs/heads/main","pushedAt":"2024-05-22T23:06:54.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow using useModal without a hook\n\nSummary: Small API change, we can just use `writeAtom` to open the modal directly, without the indirection of `const showModal = useModal(); showModal({...})`.\n\nReviewed By: quark-zju\n\nDifferential Revision: D57683160\n\nfbshipit-source-id: a31274a21468ab0e5ae2700a1189708f07c8ba53","shortMessageHtmlLink":"Allow using useModal without a hook"}},{"before":"154936c93c8e3316ccb1e81e007e0c89885df4d9","after":"bf9b93b5f97a0ae1cc4bfdbbe63f88f28915c1d5","ref":"refs/heads/main","pushedAt":"2024-05-22T23:01:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update @testing-library/react to 15.0.6\n\nSummary: This fixes an unnecessary warning in react 18.3 when running tests (warning about importing \"act\" from react)\n\nReviewed By: quark-zju\n\nDifferential Revision: D57680414\n\nfbshipit-source-id: 0763274f954ce46faee95b99a1637f00cb3d0dfd","shortMessageHtmlLink":"Update @testing-library/react to 15.0.6"}},{"before":"6634827239c0cade2437056af9d307f239317dde","after":"154936c93c8e3316ccb1e81e007e0c89885df4d9","ref":"refs/heads/main","pushedAt":"2024-05-22T20:23:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add menu item to copy file url\n\nSummary:\nAdd a menu item on changed files to copy the url to the file. Like the previous diff, this depends on the `fbcodereview.code-browser-url` config.\n\nIf the config is available, then we can run `sl url` with the file path and the relevant comparison revset to get a URL we can send to the client to copy to the clipboard.\n\nReviewed By: quark-zju\n\nDifferential Revision: D57634161\n\nfbshipit-source-id: 651b9cf56c53771eea8010622b22d30a5284789d","shortMessageHtmlLink":"Add menu item to copy file url"}},{"before":"860a4c7fdf035ee899d2ce54ba10289c25763223","after":"6634827239c0cade2437056af9d307f239317dde","ref":"refs/heads/main","pushedAt":"2024-05-22T18:23:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove 2 defunct patches\n\nReviewed By: capickett\n\nDifferential Revision: D57674987\n\nfbshipit-source-id: 456ee2b4836f81866ef8884b39adb8044c802314","shortMessageHtmlLink":"Remove 2 defunct patches"}},{"before":"30ce94b5a2ab547045c480ace56fd90d763591db","after":"860a4c7fdf035ee899d2ce54ba10289c25763223","ref":"refs/heads/main","pushedAt":"2024-05-22T17:50:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve colors in high-contrast theme\n\nSummary:\nIn high-contrast vscode theme, the \"You are here\" dag lines were rendering transparent. Let's update the vscode theme var so these render nicely everywhere.\n\nAlso, `<code>` fg is getting unset, but not its bg. Let's do both so it actually renders the text.\n\nReviewed By: quark-zju\n\nDifferential Revision: D57677525\n\nfbshipit-source-id: 336eef2c8513e74b5203e9559aea4a148f532950","shortMessageHtmlLink":"Improve colors in high-contrast theme"}},{"before":"4dd3d918541e929bbdb9b98f816d95148f1bcbbe","after":"30ce94b5a2ab547045c480ace56fd90d763591db","ref":"refs/heads/main","pushedAt":"2024-05-22T16:38:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/cab5ccb80c0681ff9560cabe76e756ea05d4c68d\nhttps://github.com/facebook/fb303/commit/305ab04da5ab1a77e63e9440c4743096207b75af\nhttps://github.com/facebook/fbthrift/commit/16252560e79afdefdb767d79eec099dc57463108\nhttps://github.com/facebook/folly/commit/7b02fb1588239dc0c002faaf7a2520be7cd5a0bb\nhttps://github.com/facebook/mvfst/commit/3d41c001e0dd1caa77fef149f5e8dbe8edd49707\nhttps://github.com/facebook/proxygen/commit/40ed24ac59f190900514a41f07539cc55e2406ab\nhttps://github.com/facebook/wangle/commit/ae5f19354a87cd4280e36b8e6446ca79a793def8\nhttps://github.com/facebookexperimental/edencommon/commit/4762cea4d7ff27bf803e3c8ceba627042a148dec\nhttps://github.com/facebookexperimental/rust-shed/commit/34981bdac880b493abcd763f9b0455bd3d874872\nhttps://github.com/facebookincubator/fizz/commit/3dc319486941a72b1c553a02da9ab5c145570f5d\n\nReviewed By: bigfootjon\n\nfbshipit-source-id: 3de9540488178e172852d2ae337988a7b088e568","shortMessageHtmlLink":"Updating submodules"}},{"before":"057a463c10765d8fd6a9260f2bbc5cb88e0ec68b","after":"4dd3d918541e929bbdb9b98f816d95148f1bcbbe","ref":"refs/heads/main","pushedAt":"2024-05-22T13:36:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve bulk derivation during initial import\n\nDifferential Revision: D57665857\n\nfbshipit-source-id: a737a6f082ec7299b9200420c5cb7928a61b50d2","shortMessageHtmlLink":"Improve bulk derivation during initial import"}},{"before":"8625711fd2be1ab8ee1e359f3d2ebcc67f5fd6c4","after":"057a463c10765d8fd6a9260f2bbc5cb88e0ec68b","ref":"refs/heads/main","pushedAt":"2024-05-22T13:02:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"rebase: fix \"reproducible commits\" for in-memory rebase\n\nSummary: We make commit hashes reproducible by removing \"mutdate\" from the commit extras. The previous attempt wasn't covering all spots (e.g. in-memory rebase). Fix by moving the \"extra\" twiddling into a \"extrafn\" which is called consistently when making commits.\n\nReviewed By: zzl0\n\nDifferential Revision: D57665331\n\nfbshipit-source-id: 984ba2ae591aabc821f058711219f13a4b82184c","shortMessageHtmlLink":"rebase: fix \"reproducible commits\" for in-memory rebase"}},{"before":"0a75b38534593f5757ccbcd3c71874e1f00edfe2","after":"8625711fd2be1ab8ee1e359f3d2ebcc67f5fd6c4","ref":"refs/heads/main","pushedAt":"2024-05-22T12:52:50.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support dangling submodule pointers in small repo config\n\nSummary:\n## Problem\nSome git repos have in their history submodule pointers to commits that don't exist.\nThis is a problem that comes with using git submodules.\n\nCurrently, if we're not able to find a commit in the submodule repo, we crash.\n\n## Solution\nBecause this mostly happens in the repo's history, it's only a problem during initial import. Let's add a new field to the small repo sync config for submodule pointers that we know are dangling.\n\nWhen such a pointer is found, instead of crashing, we'll create a changeset in the submodule repo containing a README file informing that this corresponds to a dangling submodule pointer.\n\nThis approach allows us to still detect unexpected dangling submodule pointers while correctly handling known ones.\n\n## This diff\nThis diff starts using this `dangling_submodule_pointers` field to do this.\n\nThis diff replaces all calls to `bonsai_git_mapping` in the submodule expansion code with the new function `get_submodule_bonsai_changeset_id`. This will look for the git commit in bonsai_git_mapping, but if it doesn't find it, it will check the dangling pointers list and will create the dummy changeset if required.\n\nDifferential Revision: D57621151\n\nfbshipit-source-id: 7098e0570ac3e4032e3578e37bf6b6ff2507aa42","shortMessageHtmlLink":"Support dangling submodule pointers in small repo config"}},{"before":"0564f1321a0593d8a2ddbbe9315f651f6a96b210","after":"0a75b38534593f5757ccbcd3c71874e1f00edfe2","ref":"refs/heads/main","pushedAt":"2024-05-22T11:20:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fbcode/eden/\n\nReviewed By: mitrandir77\n\nDifferential Revision: D57436407\n\nfbshipit-source-id: ce23ec280b4e98df491adb30d563cc019d2a6014","shortMessageHtmlLink":"fbcode/eden/"}},{"before":"9753eec68b327c8a8aa6449889c1de3e4580a517","after":"6c567bf8accc18e3ce9921d1d6f237c9a3a103c5","ref":"refs/heads/gh-pages","pushedAt":"2024-05-22T00:05:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 0564f1321a0593d8a2ddbbe9315f651f6a96b210","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/sapling/commit/0564f1321a0593d8a2ddbbe9315f651f6a96b210/hovercard\" href=\"https://github.com/facebook/sapling/commit/0564f1321a0593d8a2ddbbe9315f651f6a96b210\"><tt>0564f13</tt></a>"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEU8q9rQA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/sapling"}