Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-transition-group from npm #9937

Merged
merged 1 commit into from Jun 12, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 12, 2017

Note: I have not tested this yet.

This should point react-addons-transition-group to API-compatible versions of react-transition-group package. This lets it keep working in observable future. So we don't need to deprecate it officially (even though we will keep the npm package deprecated and suggest people to migrate to new package explicitly).

cc @jquense

@flarnie
Copy link
Contributor

flarnie commented Jun 12, 2017

If/when I have time I can come back to this and manually test it. I think we could use the 'browserify' fixture and require and use it there to manually test.

@gaearon
Copy link
Collaborator Author

gaearon commented Jun 12, 2017

I'm going to assume it works—I'll do another round of testing anyway as I complete preparing this, and I'd rather test them all at once.

@gaearon gaearon merged commit dea8f6a into facebook:15.6-dev Jun 12, 2017
@gaearon gaearon deleted the use-transition-group branch June 12, 2017 22:43
@jquense
Copy link
Contributor

jquense commented Jun 13, 2017

Looks like it should work to me...i don't think I changed the exports at all 👍

nhunzaker pushed a commit to nhunzaker/react that referenced this pull request Jun 13, 2017
@flarnie flarnie mentioned this pull request Jun 13, 2017
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants