Remove event pooling in the modern system #18969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 212c838:
|
Details of bundled changes.Comparing: 22f7663...212c838 react-dom
react-native-renderer
Size changes (experimental) |
Details of bundled changes.Comparing: 22f7663...212c838 react-native-renderer
react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
gaearon
approved these changes
May 21, 2020
This was referenced Mar 6, 2021
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #18216, and re-applies much of the same logic and also keeps consistency with that PR's summary. After a bunch of internal discussions, we decided we want to go ahead with this change and bring it into the modern event system.
The main difference is that now we have a proper fork of the different event systems, we don't need to apply the gated logic around a bunch of places (other than the
SyntheticEventmodule). I also had to fork a bunch of tests that expect persistance when we run the modern event system. Once we remove the feature flags, we can tidy up a load of code relating to pooling (by removing it all).