From 5190c970b79fa4f478abb9966c968ba5ec9c1396 Mon Sep 17 00:00:00 2001 From: Tom Brown Date: Wed, 15 Apr 2020 21:54:22 +0100 Subject: [PATCH 1/2] Add support for disableremoteplayback --- fixtures/attribute-behavior/src/attributes.js | 5 +++++ packages/react-dom/src/shared/DOMProperty.js | 1 + packages/react-dom/src/shared/possibleStandardNames.js | 1 + 3 files changed, 7 insertions(+) diff --git a/fixtures/attribute-behavior/src/attributes.js b/fixtures/attribute-behavior/src/attributes.js index 12f4032c8f3d..92f3a49c09e5 100644 --- a/fixtures/attribute-behavior/src/attributes.js +++ b/fixtures/attribute-behavior/src/attributes.js @@ -448,6 +448,11 @@ const attributes = [ read: getSVGAttribute('direction'), }, {name: 'disabled', tagName: 'input'}, + { + name: 'disableRemotePlayback', + tagName: 'video', + read: getProperty('disableremoteplayback'), + }, { name: 'disablePictureInPicture', tagName: 'video', diff --git a/packages/react-dom/src/shared/DOMProperty.js b/packages/react-dom/src/shared/DOMProperty.js index 68a2188b9850..abf90cfa9ea5 100644 --- a/packages/react-dom/src/shared/DOMProperty.js +++ b/packages/react-dom/src/shared/DOMProperty.js @@ -336,6 +336,7 @@ reservedProps.forEach(name => { 'defer', 'disabled', 'disablePictureInPicture', + 'disableRemotePlayback', 'formNoValidate', 'hidden', 'loop', diff --git a/packages/react-dom/src/shared/possibleStandardNames.js b/packages/react-dom/src/shared/possibleStandardNames.js index 80a17ba100c7..516e20b0f6e8 100644 --- a/packages/react-dom/src/shared/possibleStandardNames.js +++ b/packages/react-dom/src/shared/possibleStandardNames.js @@ -55,6 +55,7 @@ const possibleStandardNames = { dir: 'dir', disabled: 'disabled', disablepictureinpicture: 'disablePictureInPicture', + disableremoteplayback: 'disableRemotePlayback', download: 'download', draggable: 'draggable', enctype: 'encType', From adaff1a35f2558bbe55236924908b746e229c254 Mon Sep 17 00:00:00 2001 From: Tom Brown Date: Wed, 15 Apr 2020 22:09:17 +0100 Subject: [PATCH 2/2] Order attributes alphabetically --- fixtures/attribute-behavior/src/attributes.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fixtures/attribute-behavior/src/attributes.js b/fixtures/attribute-behavior/src/attributes.js index 92f3a49c09e5..17d7767bcc50 100644 --- a/fixtures/attribute-behavior/src/attributes.js +++ b/fixtures/attribute-behavior/src/attributes.js @@ -449,14 +449,14 @@ const attributes = [ }, {name: 'disabled', tagName: 'input'}, { - name: 'disableRemotePlayback', + name: 'disablePictureInPicture', tagName: 'video', - read: getProperty('disableremoteplayback'), + read: getProperty('disablepictureinpicture'), }, { - name: 'disablePictureInPicture', + name: 'disableRemotePlayback', tagName: 'video', - read: getProperty('disablepictureinpicture'), + read: getProperty('disableremoteplayback'), }, { name: 'display',