New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unstable_renderSubtreeIntoContainer and unstable_createPortal feature flags #17880
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46cee59:
|
Details of bundled changes.Comparing: 0c04aca...46cee59 react-dom
Size changes (experimental) |
Details of bundled changes.Comparing: 0c04aca...46cee59 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
d0de0a5
to
da119d5
Compare
0a96835
to
0447b41
Compare
…ture flags Add flags to other files address feedback Fix The ReactDOM.unstable_createPortal() Trigger build Make message same as before
0447b41
to
e327e4a
Compare
Just a question: does this mean that portals will be deprecated in the future? |
No, in fact the opposite. It means the unstable_ prefixed version for createPortal is removed. Use just createPortal instead. |
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
This was added back in facebook#17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since.
This was added back in #17880 to make CI pass for an unrelated change. This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
This was added back in #17880 to make CI pass for an unrelated change. This limits the max worker setting to CI environments as removing the setting completely still seems to break on CircleCI.
This PR adds two feature flags:
disableUnstableRenderSubtreeIntoContainer
forReactDOM.unstable_renderSubtreeIntoContainer
disableUnstableCreatePortal
forReactDOM.unstable_createPortal
These disable the relevant unstable/deprecated ReactDOM APIs. Additionally
ReactDOM.unstable_renderSubtreeIntoContainer
has a deprecation warning message as follows:The ReactDOM.unstable_renderSubtreeIntoContainer() is deprecated and will be removed in a future major release. Consider using React Portals instead.
I also changed the flowconfig to have the follow config, otherwise CI fails on this PR:
server.max_workers=4