From 9b1d1839b3d749cf4122f6cff970b2f5cbc0401a Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Fri, 3 Jan 2020 16:07:33 -0800 Subject: [PATCH] Remove toString of dangerouslySetInnerHTML As far as I can tell, the toString call was added here: https://github.com/facebook/react/commit/caae627cd557812d28d11237b34bff6c661ea8bc#diff-5574f655d491348f422bca600ff6711dR887 It was never really needed. Subsequently when we added Trusted Types, this needed to be changed to a special call but we really should just always let it pass through. --- packages/react-dom/src/client/ReactDOMComponent.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/react-dom/src/client/ReactDOMComponent.js b/packages/react-dom/src/client/ReactDOMComponent.js index 670d5a70e6f3..e5111ae60356 100644 --- a/packages/react-dom/src/client/ReactDOMComponent.js +++ b/packages/react-dom/src/client/ReactDOMComponent.js @@ -85,7 +85,6 @@ import possibleStandardNames from '../shared/possibleStandardNames'; import {validateProperties as validateARIAProperties} from '../shared/ReactDOMInvalidARIAHook'; import {validateProperties as validateInputProperties} from '../shared/ReactDOMNullInputValuePropHook'; import {validateProperties as validateUnknownProperties} from '../shared/ReactDOMUnknownPropertyHook'; -import {toStringOrTrustedType} from './ToStringValue'; import { enableDeprecatedFlareAPI, @@ -787,10 +786,7 @@ export function diffProperties( const lastHtml = lastProp ? lastProp[HTML] : undefined; if (nextHtml != null) { if (lastHtml !== nextHtml) { - (updatePayload = updatePayload || []).push( - propKey, - toStringOrTrustedType(nextHtml), - ); + (updatePayload = updatePayload || []).push(propKey, nextHtml); } } else { // TODO: It might be too late to clear this if we have children