Remove concurrent apis from stable #17088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: -0.0%, gzip: -0.1% Details of bundled changes.Comparing: a8c6a1b...38e5bb7 react-dom
|
sebmarkbage
reviewed
Oct 14, 2019
| @@ -643,7 +624,7 @@ type RootOptions = { | |||
| }, | |||
| }; | |||
|
|
|||
| function createRoot( | |||
| export function createRoot( | |||
There was a problem hiding this comment.
We shouldn't do exports here, right? Why would you?
There was a problem hiding this comment.
It's so I can add a prefixed version to the Facebook build:
react/packages/react-dom/src/client/ReactDOMFB.js
Lines 36 to 37 in 09d07e2
I forgot this module is the public interface... I think it happens to work because only the .default export is reexported in the Common JS bundle, but maybe a better approach is to move the createRoot and other implementation stuff into a separate module.
There was a problem hiding this comment.
Ok after talking offline, I've removed this. www will use the experimental builds.
acdlite
force-pushed
the
remove-concurrent-apis-from-stable
branch
2 times, most recently
from
653ffa7
to
8fbca06
Compare
For local development, you usually want experiments enabled. Unless the release channel is set with an environment variable, tests will run with __EXPERIMENTAL__ set to `true`.
Those who want to try concurrent mode should use the experimental builds instead. I've left the `unstable_` prefixed APIs in the Facebook build so we can continue experimenting with them internally without blessing them for widespread use.
acdlite
force-pushed
the
remove-concurrent-apis-from-stable
branch
4 times, most recently
from
ccf2758
to
dca8802
Compare
Instead we'll use the experimental builds when syncing to www.
sebmarkbage
approved these changes
Oct 15, 2019
This was referenced Oct 30, 2019
This was referenced Apr 11, 2020
This was referenced Apr 21, 2020
This was referenced May 2, 2020
Closed
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those who want to try concurrent mode should use the experimental builds instead.
I also turned on the Suspense server renderer and selective hydration in the experimental build.