From dfe632df3efc5231a18eb000deb0ac8cc6786f15 Mon Sep 17 00:00:00 2001 From: Sebastian Markbage Date: Sun, 11 Aug 2019 12:48:48 -0700 Subject: [PATCH] Reset didReceiveUpdate in beginWork This is a bad bug. It means that we sometimes inherit didReceiveUpdate from a previous component's begin. Effectively this only means that we're overrendering in some cases. We should refactor to get rid of this as a global flag. --- packages/react-reconciler/src/ReactFiberBeginWork.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react-reconciler/src/ReactFiberBeginWork.js b/packages/react-reconciler/src/ReactFiberBeginWork.js index 02e26ae74627..88fdf4c1ac41 100644 --- a/packages/react-reconciler/src/ReactFiberBeginWork.js +++ b/packages/react-reconciler/src/ReactFiberBeginWork.js @@ -2846,6 +2846,8 @@ function beginWork( workInProgress, renderExpirationTime, ); + } else { + didReceiveUpdate = false; } } else { didReceiveUpdate = false;