Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove React.createMixin #8852

Closed
aweary opened this issue Jan 23, 2017 · 3 comments
Closed

Remove React.createMixin #8852

aweary opened this issue Jan 23, 2017 · 3 comments
Assignees
@aweary

Comments

@aweary
Copy link
Contributor

aweary commented Jan 23, 2017

Since mixins are no longer a part of the future React API plan, and the current React.createMixin implementation is just a no-op, I think we can consider removing it.

Since it was part of the public API I believe it would need to happen in the next major release. Should we add a deprecation warning before then? There are a number of projects that use the API.

cc @spicyj @gaearon
@gaearon
Copy link
Collaborator

gaearon commented Jan 23, 2017

Yes let's get rid of it. Want to send a PR to add a deprecation warning?

@aweary aweary self-assigned this Jan 23, 2017
@aweary aweary mentioned this issue Jan 24, 2017
Merged
@kaushik94
Copy link

@aweary can I work on this one? Since I am new to the community, I might need a bit of direction as to where to start.

@gaearon
Copy link
Collaborator

gaearon commented Feb 6, 2017

@kaushik94 It’s already been done as part of #8853, I just forgot to close the issue. Sorry!

@gaearon gaearon closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aweary aweary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaearon @kaushik94 @aweary