Warn for string refs where owner != __self

[jimfb]

Sebastian wants to warn when owner !== __self, because this is the hard case to find when codemodding from string refs to callback refs.

[aweary]

Would this likely be done in ReactOwner.addComponentAsRefTo?

[jimfb]

Probably would be a separate dev tool that sanity checked the element when the element is being mounted. But we'll need to fix the transform first, since I don't think we're even using the __self prop right now, IIRC.

[aweary]

Which transform are you referring to? I'd like to take a look at this if possible.

I don't think we're even using the __source prop

Do you mean __self or is __source required here too?

[jimfb]

Sorry, yeah, __self, edited/fixed in reply above.

Which transform are you referring to? I'd like to take a look at this if possible.

babel/babel#3540

[keyz]

How would this affect people who use createElement explicitly?

[jimfb]

@keyanzhang They miss out on a potentially useful warning. Unfortunately, there really isn't much we can do to make their experience any better, AFAIK.

[jimfb]

cc @facebook/react-core Public API change.

[sophiebits]

Well you could also make a transform that adds __self to React.createElement calls.

We always wanted to log this internally – not 100% sure it makes sense to give a warning externally too? I guess it's probably reasonable.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

[sebmarkbage]

This is something we actually should do soon as part of deprecations work. If we first get rid of these edge cases then it will allow us to write a codemod for string refs.

[stale]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[gaearon]

bump

[stale]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

[rickhanlonii]

Bump

[lunaruan]

This is closed by #17864.