[Flight] Error if a legacy React Element is attempted to be rendered #29043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
force-pushed
the
rsclegacyelement
branch
from
c1f1049
to
14b5add
Compare
eps1lon
approved these changes
May 10, 2024
| throw new Error( | ||
| 'A React Element from an older version of React was rendered. ' + | ||
| 'This is not supported. It can happen if:\n' + | ||
| '- Multiple copies of the "react" package is used.\n' + |
There was a problem hiding this comment.
Suggested change
| '- Multiple copies of the "react" package is used.\n' + | |
| '- Multiple copies of the "react" package are used.\n' + |
| expectedMessage={ | ||
| 'A React Element from an older version of React was rendered. ' + | ||
| 'This is not supported. It can happen if:\n' + | ||
| '- Multiple copies of the "react" package is used.\n' + |
There was a problem hiding this comment.
Suggested change
| '- Multiple copies of the "react" package is used.\n' + | |
| '- Multiple copies of the "react" package are used.\n' + |
sebmarkbage
force-pushed
the
rsclegacyelement
branch
from
14b5add
to
0d701bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This errors on the client normally but in the case the
typeis a function - i.e. a Server Component - it wouldn't be transferred to error on the client so you end up with a worse error message. So this just implements the same check as ChildFiber.