Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: No warning on infinite useEffect loop in React 18 #24203

Closed
gaearon opened this issue Mar 29, 2022 · 5 comments · Fixed by #24295
Closed

Bug: No warning on infinite useEffect loop in React 18 #24203

gaearon opened this issue Mar 29, 2022 · 5 comments · Fixed by #24295
Labels
React 18 Bug reports, questions, and general feedback about React 18 Type: Bug

Comments

@gaearon
Copy link
Collaborator

gaearon commented Mar 29, 2022

https://codesandbox.io/s/elastic-mayer-rzz4h2?file=/package.json

This is supposed to console.error but it doesn't.

17 warns: https://codesandbox.io/s/admiring-minsky-sze07m?file=/src/App.js
@gaearon gaearon added Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug React 18 Bug reports, questions, and general feedback about React 18 and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Mar 29, 2022
@arunavabasu-03
Copy link

Hey @gaearon, i want to work on this issue.

@gaearon
Copy link
Collaborator Author

gaearon commented Mar 31, 2022

You’re welcome to submit a PR but I don’t know how to fix it so I won’t be able to guide you. When there’s no one to guide, we don’t “assign” issues to a specific person.

@arunavabasu-03
Copy link

arunavabasu-03 commented Mar 31, 2022 •
edited

that's ok 👍

@gaearon gaearon mentioned this issue Apr 7, 2022
Merged
@gaearon
Copy link
Collaborator Author

gaearon commented Apr 7, 2022

I have a fix in #24295.

@arunavabasu-03
Copy link

Great !! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
React 18 Bug reports, questions, and general feedback about React 18 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warning about setState in useEffect gaearon/react
2 participants
@gaearon @arunavabasu-03