Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: disableRemotePlayback not recognized #18618

Closed
tomprats opened this issue Apr 15, 2020 · 3 comments
Closed

Bug: disableRemotePlayback not recognized #18618

tomprats opened this issue Apr 15, 2020 · 3 comments
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@tomprats
Copy link

Passing disableRemotePlayback as an attribute like so:

<video disableRemotePlayback={true}>

Produces the warning:

Warning: React does not recognize the disableRemotePlayback prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase disableremoteplayback instead. If you accidentally passed it from a parent component, remove it from the DOM element.

It seems like React should recognize it's similar to #15334.

React version: 16.13.1

The current behavior

Warning and not rendering the attribute

The expected behavior

Adding the attribute similar to how it'd render disablePictureInPicture with a final output of:

<video disableRemotePlayback ...>

When rendering it with:

<video disableRemotePlayback={true} ...>
@tomprats tomprats added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Apr 15, 2020
@tombrowndev
Copy link
Contributor

tombrowndev commented Apr 15, 2020

Created a PR #18619

@tombrowndev
Copy link
Contributor

@tomprats This has been merged in. Feel free to close the issue,

Cheers

@tomprats
Copy link
Author

Thanks @tombrowndev, appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

2 participants