Remove feature flag around 'getDerivedStateFromProps' bug fix #13022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** Basically undoes facebook@4b2e65d#diff-904ceabd8a1e9a07ab1d876d843d62e1 **why make this change?:** We rolled out this fix internally and in open source weeks ago, and now we're cleaning up. **test plan:** Ran tests and lint, and really we have been testing this because the flag is open internally as of last week or so. **issue:** Internal task T29948812 has some info.
gaearon
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
Basically undoes 4b2e65d#diff-904ceabd8a1e9a07ab1d876d843d62e1
why make this change?:
We rolled out this fix internally and in open source weeks ago, and now
we're cleaning up.
test plan:
Ran tests and lint, and really we have been testing this because the
flag is open internally as of last week or so.
issue:
Internal task T29948812 has some info.
Will follow up by removing internal code which uses this flag, after syncing this. Probably this Tues./Weds. or early next week.