Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Calling ReactNative.findNodeHandle() in render() crashes in DEV #10518

Closed
gaearon opened this issue Aug 23, 2017 · 1 comment
Closed

[Fiber] Calling ReactNative.findNodeHandle() in render() crashes in DEV #10518

gaearon opened this issue Aug 23, 2017 · 1 comment
Assignees
@bvaughn

Comments

@gaearon
Copy link
Collaborator

gaearon commented Aug 23, 2017 •
edited

Found this while working on #10517.
See #10517 (comment) for more details.

screen shot 2017-08-23 at 1 20 31 pm

screen shot 2017-08-23 at 1 20 56 pm

Now I know this has been fixed in #10448 but that’s not the whole story.

Even if we fixed the Stack-assuming getName() call, we still can't put arbitrary fields on a fiber:

screen shot 2017-08-23 at 1 21 55 pm

For the reference, this is how we work around the problem in ReactDOM.
@gaearon gaearon mentioned this issue Aug 23, 2017
Merged
gaearon added a commit to gaearon/react that referenced this issue Aug 23, 2017
@gaearon
Add FlowFixMe for facebook#10518
c9d711e
This was referenced Aug 23, 2017
Closed
Closed
@bvaughn
Copy link
Contributor

bvaughn commented Aug 23, 2017

I'm on it.

@bvaughn bvaughn mentioned this issue Aug 23, 2017
Merged
@bvaughn bvaughn closed this as completed Aug 23, 2017
@gaearon gaearon mentioned this issue Oct 4, 2017
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bvaughn @gaearon @acdlite