Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncontrolled radio fix is breaking master #10196

Closed
gaearon opened this issue Jul 16, 2017 · 9 comments · Fixed by #10207
Closed

Uncontrolled radio fix is breaking master #10196

gaearon opened this issue Jul 16, 2017 · 9 comments · Fixed by #10207

Comments

@gaearon
Copy link
Collaborator

gaearon commented Jul 16, 2017

I'm not sure why but #10156 seems to have caused issues in production with us. We'll need to either revert or find a way to fix forward. Right now master is broken, and if we sync again before fixing, we'll break things.

@jquense
Copy link
Contributor

jquense commented Jul 16, 2017

Is there anymore info about what breaks and when? I imagine it's the instances vs DOM node check is failing but it's tough to guess why without a repro.

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 16, 2017

We just got reports from production with the invariant triggering, it’s hard to say what exactly is being passed there. We’ll try to reproduce tomorrow.

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 16, 2017

As a first step would you mind rewriting inputValueTracking-test.js in terms of public API? For example instead of calling that function directly, you could call ReactDOM.render and then make assertions on DOM by getting a ref to the input. This way we'll likely find where it broke in Fiber.

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 16, 2017

Left a few more questions in #10156 (review)

@jquense
Copy link
Contributor

jquense commented Jul 16, 2017

I can definitely rewrite the tests, though for all intents and purposes the ChangeEventPlugin tests already do that. Which is to say, in terms of the public API the only visible effect is whether change events fire more than once per value.

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 16, 2017

Hmmm I see. I was thinking about making tests still test implementation details (like wrappers) but use them through ReactDOM.render so we can be sure correct thing is being passed as argument to inputTracker. But maybe that won't help if we already cover these scenarios.

@jquense
Copy link
Contributor

jquense commented Jul 16, 2017

well it can't hurt :P I can see if it uncovers anything anyway

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 17, 2017

Tracked down the cause. #10156 (comment)

@gaearon
Copy link
Collaborator Author

gaearon commented Jul 18, 2017

#10207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants