Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntheticEvent.augmentClass undefined in QtWebKit browsers #10010

Closed
hotboi64 opened this issue Jun 20, 2017 · 3 comments
Closed

SyntheticEvent.augmentClass undefined in QtWebKit browsers #10010

hotboi64 opened this issue Jun 20, 2017 · 3 comments

Comments

@hotboi64
Copy link

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Everything seems terrible.
In a certain WebKit browser, https://github.com/annulen/webkit, a page that pulls in a bundled script doesn't seem to finish loading, with console errors about augmentClass being undefined

Build details:
webpack-ing,
using babel-loader with es2015 and react presets in webpack.config.js

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/84v837e9/).
After building,
use a QtWebKit test browser from ./WebKitBuild/Release/bin/QtTestBrowser to visit the offending page

What is the expected behavior?
to not see complaints about SyntheticEvent in the console

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
react and react-dom 15.4
QtWebKit 5.212

@walrusfruitcake
Copy link
Contributor

Upon debugging just before the SyntheticEvent module export, it appears SyntheticEvent.augmentClass is undefined, but the SyntheticEvent.Interface assignment is EventInterface as we'd expect.

@walrusfruitcake
Copy link
Contributor

#10011

@gaearon
Copy link
Collaborator

gaearon commented Jul 11, 2017

Fixed by #10011.
But no promises this won't break again.

@gaearon gaearon closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants