From da03cbad75dcce3b318e98c7e26d658925fedba2 Mon Sep 17 00:00:00 2001 From: Nathan Hunzaker Date: Mon, 23 Jan 2017 08:37:53 -0500 Subject: [PATCH] Update ReactDOM children tests to use createElement These tests were throwing warnings because of the new deprecation of React.DOM. Also re-records fiber tests. --- scripts/fiber/tests-failing.txt | 4 ---- scripts/fiber/tests-passing.txt | 2 ++ src/renderers/dom/shared/__tests__/ReactDOM-test.js | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/scripts/fiber/tests-failing.txt b/scripts/fiber/tests-failing.txt index 00f649c78dedc..7ab7803ab368e 100644 --- a/scripts/fiber/tests-failing.txt +++ b/scripts/fiber/tests-failing.txt @@ -9,10 +9,6 @@ src/isomorphic/classic/__tests__/ReactContextValidator-test.js src/renderers/dom/__tests__/ReactDOMProduction-test.js * should throw with an error code in production -src/renderers/dom/shared/__tests__/ReactDOM-test.js -* should allow children to be passed as an argument -* should overwrite props.children with children argument - src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js * should clean up input value tracking * should clean up input textarea tracking diff --git a/scripts/fiber/tests-passing.txt b/scripts/fiber/tests-passing.txt index 3f79ff1173705..030b84ac752bc 100644 --- a/scripts/fiber/tests-passing.txt +++ b/scripts/fiber/tests-passing.txt @@ -627,6 +627,8 @@ src/renderers/dom/shared/__tests__/ReactBrowserEventEmitter-test.js src/renderers/dom/shared/__tests__/ReactDOM-test.js * allows a DOM element to be used with a string +* should allow children to be passed as an argument +* should overwrite props.children with children argument * should purge the DOM cache when removing nodes * throws in render() if the mount callback is not a function * throws in render() if the update callback is not a function diff --git a/src/renderers/dom/shared/__tests__/ReactDOM-test.js b/src/renderers/dom/shared/__tests__/ReactDOM-test.js index 96267ae551267..31f26e6e521b9 100644 --- a/src/renderers/dom/shared/__tests__/ReactDOM-test.js +++ b/src/renderers/dom/shared/__tests__/ReactDOM-test.js @@ -53,7 +53,7 @@ describe('ReactDOM', () => { it('should allow children to be passed as an argument', () => { var argDiv = ReactTestUtils.renderIntoDocument( - React.DOM.div(null, 'child') + React.createElement('div', null, 'child') ); var argNode = ReactDOM.findDOMNode(argDiv); expect(argNode.innerHTML).toBe('child'); @@ -61,7 +61,7 @@ describe('ReactDOM', () => { it('should overwrite props.children with children argument', () => { var conflictDiv = ReactTestUtils.renderIntoDocument( - React.DOM.div({children: 'fakechild'}, 'child') + React.createElement('div', {children: 'fakechild'}, 'child') ); var conflictNode = ReactDOM.findDOMNode(conflictDiv); expect(conflictNode.innerHTML).toBe('child');