From 6fd72ce08e4355a9109314b3858a973e48dd8b1d Mon Sep 17 00:00:00 2001 From: Nick Reiley Date: Sat, 4 Apr 2020 15:56:04 +0500 Subject: [PATCH] make onKeyPress work --- .../src/events/__tests__/SyntheticKeyboardEvent-test.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js b/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js index 2b56d6b3f3c81..aa16988d39747 100644 --- a/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js +++ b/packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js @@ -453,7 +453,7 @@ describe('SyntheticKeyboardEvent', () => { }); describe('code', () => { - it('returns code on `keydown`, `keyup` and null on `keypress`', () => { + it('returns code on `keydown`, `keyup` and on `keypress`', () => { let codeDown = null; let codeUp = null; let codePress = null; @@ -488,13 +488,14 @@ describe('SyntheticKeyboardEvent', () => { node.dispatchEvent( new KeyboardEvent('keypress', { code: 'KeyQ', + charCode: 113, bubbles: true, cancelable: true, }), ); expect(codeDown).toBe('KeyQ'); expect(codeUp).toBe('KeyQ'); - expect(codePress).toBe(null); + expect(codePress).toBe('KeyQ'); }); }); });