From 618ed0358f0491d7568369fa035200fccfa4997c Mon Sep 17 00:00:00 2001 From: Nathan Hunzaker Date: Mon, 21 Nov 2016 20:48:52 -0500 Subject: [PATCH] Tweak test to avoid awkward eslint warning --- src/addons/__tests__/ReactDOMFactories-test.js | 17 ++++++++--------- src/isomorphic/React.js | 2 +- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/addons/__tests__/ReactDOMFactories-test.js b/src/addons/__tests__/ReactDOMFactories-test.js index 23701750d51dc..7f3baefefc405 100644 --- a/src/addons/__tests__/ReactDOMFactories-test.js +++ b/src/addons/__tests__/ReactDOMFactories-test.js @@ -11,14 +11,10 @@ 'use strict'; -describe('ReactDOMFactories', () => { - var React; - var {div} = require('ReactDOMFactories'); - - beforeEach(function () { - React = require('React'); - }) +var React = require('React'); +var {div} = require('ReactDOMFactories'); +describe('ReactDOMFactories', () => { it('allow factories to be called without warnings', () => { spyOn(console, 'error'); var element = div(); @@ -29,8 +25,11 @@ describe('ReactDOMFactories', () => { it('warns once when accessing React.DOM methods', () => { spyOn(console, 'error'); - React.DOM.div; - React.DOM.p; + var a = React.DOM.a(); + var p = React.DOM.p(); + + expect(a.type).toBe('a'); + expect(p.type).toBe('p'); expectDev(console.error.calls.count()).toBe(1); }); diff --git a/src/isomorphic/React.js b/src/isomorphic/React.js index 5678ef673d935..53818fe6050ca 100644 --- a/src/isomorphic/React.js +++ b/src/isomorphic/React.js @@ -98,7 +98,7 @@ if (__DEV__) { var hasWarnedOfFactories = false; React.DOM = new Proxy(React.DOM, { - get: function (target, name) { + get: function(target, name) { if (!hasWarnedOfFactories) { warning( false,