diff --git a/docs/docs/addons.md b/docs/docs/addons.md index de05678924631..c9ac2ea787e30 100644 --- a/docs/docs/addons.md +++ b/docs/docs/addons.md @@ -12,8 +12,7 @@ The React add-ons are a collection of useful utility modules for building React The add-ons below are in the development (unminified) version of React only: - [`Perf`](perf.html), a performance profiling tool for finding optimization opportunities. -- [`ReactTestUtils`](test-utils.html), simple helpers for writing test - cases. +- [`ReactTestUtils`](test-utils.html), simple helpers for writing test cases. ### Legacy Add-ons diff --git a/src/addons/__tests__/ReactDOMFactories-test.js b/src/addons/__tests__/ReactDOMFactories-test.js index 272c1923dc060..df43b1d20d382 100644 --- a/src/addons/__tests__/ReactDOMFactories-test.js +++ b/src/addons/__tests__/ReactDOMFactories-test.js @@ -11,9 +11,6 @@ 'use strict'; -var React = require('React'); -var ReactDOM = require('ReactDOM'); -var ReactTestUtils = require('ReactTestUtils'); var {div} = require('ReactDOMFactories'); describe('ReactDOMFactories', () => { @@ -25,40 +22,4 @@ describe('ReactDOMFactories', () => { expectDev(console.error.calls.count()).toBe(0); }); - it('identifies valid elements', () => { - var Component = React.createClass({ - render: function() { - return React.createElement('div'); - }, - }); - expect(React.isValidElement(div)).toEqual(false); - }); - - it('identifies elements, but not JSON, if Symbols are supported', () => { - // Rudimentary polyfill - // Once all jest engines support Symbols natively we can swap this to test - // WITH native Symbols by default. - var REACT_ELEMENT_TYPE = function() {}; // fake Symbol - var OTHER_SYMBOL = function() {}; // another fake Symbol - global.Symbol = function(name) { - return OTHER_SYMBOL; - }; - global.Symbol.for = function(key) { - if (key === 'react.element') { - return REACT_ELEMENT_TYPE; - } - return OTHER_SYMBOL; - }; - - jest.resetModuleRegistry(); - - React = require('React'); - - var Component = React.createClass({ - render: function() { - return React.createElement('div'); - }, - }); - expect(React.isValidElement(div)).toEqual(false); - }); }); diff --git a/src/isomorphic/classic/element/__tests__/ReactElement-test.js b/src/isomorphic/classic/element/__tests__/ReactElement-test.js index 0ffabd50a43ac..41066734027d3 100644 --- a/src/isomorphic/classic/element/__tests__/ReactElement-test.js +++ b/src/isomorphic/classic/element/__tests__/ReactElement-test.js @@ -353,6 +353,7 @@ describe('ReactElement', () => { expect(React.isValidElement(true)).toEqual(false); expect(React.isValidElement({})).toEqual(false); expect(React.isValidElement('string')).toEqual(false); + expect(React.isValidElement(React.createFactory('div'))).toEqual(false); expect(React.isValidElement(Component)).toEqual(false); expect(React.isValidElement({ type: 'div', props: {} })).toEqual(false); @@ -516,6 +517,7 @@ describe('ReactElement', () => { expect(React.isValidElement(true)).toEqual(false); expect(React.isValidElement({})).toEqual(false); expect(React.isValidElement('string')).toEqual(false); + expect(React.isValidElement(React.createFactory('div'))).toEqual(false); expect(React.isValidElement(Component)).toEqual(false); expect(React.isValidElement({ type: 'div', props: {} })).toEqual(false); @@ -598,7 +600,13 @@ describe('comparing jsx vs .createFactory() vs .createElement()', () => { beforeEach(() => { var Parent = React.createClass({ render: function() { - return React.createElement('div', {}, React.createElement(Child, { ref: 'child', foo: 'foo value' }, 'children value')); + return ( + React.createElement('div', null, + React.createElement(Child, { + ref: 'child', + foo: 'foo value', + }, 'children value')) + ); }, }); factory = React.createFactory(Parent);