-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcut emitDeviceEvent in bridgeless #44574
Conversation
This pull request was exported from Phabricator. Differential Revision: D57329165 |
Base commit: 13dff7c |
Summary: `emitDeviceEvent` is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D57329165
This pull request was exported from Phabricator. Differential Revision: D57329165 |
Summary: `emitDeviceEvent` is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D57329165
This pull request was exported from Phabricator. Differential Revision: D57329165 |
Summary: `emitDeviceEvent` is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: RSNara Differential Revision: D57329165
This pull request has been merged in d0bb396. |
This pull request was successfully merged by @javache in d0bb396. When will my fix make it into a release? | How to file a pick request? |
This pull request has been reverted by ad4c39e. |
Summary:
emitDeviceEvent
is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module.Changelog: [Internal]
Differential Revision: D57329165