Fix CircleCI Android GTest Build #44562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57299969 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2024
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal} Differential Revision: D57299969
NickGerleman
force-pushed
the
export-D57299969
branch
from
a9e6bff
to
bdd2646
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57299969 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2024
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Differential Revision: D57299969
NickGerleman
force-pushed
the
export-D57299969
branch
from
bdd2646
to
a2e6e88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57299969 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2024
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Reviewed By: joevilches, realsoelynn Differential Revision: D57299969
NickGerleman
force-pushed
the
export-D57299969
branch
from
a2e6e88
to
6433393
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Summary: D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well. Changelog: [Internal] Reviewed By: joevilches, realsoelynn Differential Revision: D57299969
NickGerleman
force-pushed
the
export-D57299969
branch
from
6433393
to
c9a0b90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57299969 |
Base commit: 082e29e |
|
This pull request has been merged in 5a100ae. |
|
This pull request was successfully merged by @NickGerleman in 5a100ae. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D56963463 deleted some tests for code it also deleted. This broke the Android GTest OSS build, which is a centralized list of these test files. Remove from there as well.
Changelog: [Internal}
Differential Revision: D57299969