Remove folly::dynamic AttributedString storage #44512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56963463 |
NickGerleman
force-pushed
the
export-D56963463
branch
from
5c390d3
to
d6e5905
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 10, 2024
Summary: We only ever go through MapBuffer now, so we can remove the code related to storing text fragments in folly::dynamic. Changelog: [Internal] Reviewed By: rshest Differential Revision: D56963463
|
This pull request was exported from Phabricator. Differential Revision: D56963463 |
Summary: We only ever go through MapBuffer now, so we can remove the code related to storing text fragments in folly::dynamic. Changelog: [Internal] Reviewed By: rshest Differential Revision: D56963463
NickGerleman
force-pushed
the
export-D56963463
branch
from
d6e5905
to
9e14ee9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56963463 |
|
This pull request has been merged in fd8f1f5. |
|
This pull request was successfully merged by @NickGerleman in fd8f1f5. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We only ever go through MapBuffer now, so we can remove the code related to storing text fragments in folly::dynamic.
Changelog: [Internal]
Differential Revision: D56963463