redefinition of module 'ReactCommon' iOS

[daimonkor]

Description

/ios/Pods/Headers/Public/ReactCommon/ReactCommon.modulemap:1:8: error: redefinition of module 'ReactCommon' module ReactCommon { ^ /ios/Pods/Headers/Public/ReactCommon/React-RuntimeApple.modulemap:1:8: note: previously defined here module ReactCommon { ^ 1 error generated.

Steps to reproduce

1. react-nativre upgrade to 0.74.0 (from 0.73.8)

React Native Version

0.74.1

Affected Platforms

Build - MacOS

Output of npx react-native info

System:
  OS: macOS 14.4.1
  CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
  Memory: 256.48 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.8.0
    path: ~/.nvm/versions/node/v20.8.0/bin/node
  Yarn:
    version: 1.22.21
    path: /Volumes/Ext/Projects/ReactNative/outcome-mobile/node_modules/.bin/yarn
  npm:
    version: 10.2.0
    path: ~/.nvm/versions/node/v20.8.0/bin/npm
  Watchman:
    version: 2023.10.02.00
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/usersmart/.gem/ruby/3.2.2/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.4
      - iOS 17.4
      - macOS 14.4
      - tvOS 17.4
      - visionOS 1.1
      - watchOS 10.4
  Android SDK:
    API Levels:
      - "23"
      - "25"
      - "26"
      - "27"
      - "28"
      - "29"
      - "30"
      - "31"
      - "32"
      - "33"
      - "34"
    Build Tools:
      - 23.0.1
      - 25.0.2
      - 26.0.3
      - 27.0.3
      - 28.0.2
      - 28.0.3
      - 29.0.2
      - 29.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 33.0.0
      - 33.0.1
      - 33.0.2
      - 34.0.0
    System Images:
      - android-22 | Google APIs Intel x86_64 Atom
      - android-23 | Google APIs Intel x86 Atom_64
      - android-26 | Google APIs ARM 64 v8a
      - android-28 | Google APIs Intel x86 Atom
      - android-29 | Google APIs Intel x86 Atom_64
      - android-29 | Google Play Intel x86 Atom
      - android-30 | Google Play Intel x86 Atom_64
      - android-31 | Intel x86_64 Atom
      - android-31 | Google APIs Intel x86_64 Atom
      - android-31 | Google Play Intel x86 Atom_64
      - android-32 | Google APIs Intel x86_64 Atom
      - android-33 | Google APIs ARM 64 v8a
      - android-33 | Google APIs Intel x86_64 Atom
      - android-33 | Google Play Intel x86_64 Atom
      - android-34 | Google APIs Intel x86_64 Atom
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.3 AI-233.14808.21.2331.11709847
  Xcode:
    version: 15.3/15E204a
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8
    path: /usr/bin/javac
  Ruby:
    version: 3.2.2
    path: /Users/usersmart/.rubies/ruby-3.2.2/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

❌  /Volumes/Ext/Projects/ReactNative/outcome-mobile/ios/Pods/Headers/Public/ReactCommon/ReactCommon.modulemap:1:8: redefinition of module 'ReactCommon'

module ReactCommon {
                                                                   ^

Reproducer

1. react-nativer upgrade 0.74.1
2. react-native run-ios

Screenshots and Videos

No response

[github-actions]

⚠️

Newer Version of React Native is Available!

ℹ️

You are on a supported minor version, but it looks like there's a newer patch available - 0.74.1. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

[daimonkor]

⚠️ Newer Version of React Native is Available!
ℹ️ You are on a supported minor version, but it looks like there's a newer patch available - 0.74.1. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

Upgraded to 0.74.1, bug reproduced again

[KikotVit]

Same issue.
I have tried to delete the declaration of that module manually
module ReactCommon { ... (everything in file)
And it works for me.
But it looks weird...

[daimonkor]

Same issue. I have tried to delete the declaration of that module manually module ReactCommon { ... (everything in file) And it works for me. But it looks weird...

Looks like magic, maybe it needed wait command developer response

[justbaum30]

I have also run into this issue and reported it here - reactwg/react-native-releases#284

This includes a reproducer project if that is needed:
https://github.com/justbaum30/rn-74-upgrade-reproducer

[johnny-mcfadden-dailypay]

+1

[TwistedMinda]

Same issue. I have tried to delete the declaration of that module manually module ReactCommon { ... (everything in file) And it works for me. But it looks weird...

Yep, can build locally with the removal of ReactCommon, but breaks CI/CD obviously, therefore prevents upgrade to 74

[cipolleschi]

The issue does not have a reproducer, so I can't investigate it.
Have a look at this other issue, specifically, this comment.

If you are using Firebase, make sure to install pods as static frameworks and to follow the firebase installation instructions
If you are using RNCheckNotificationPermission, this library has a bug in one of the imports

[MtoagF]

Redefinition of module 'ReactCommon'

when i installed fireabse in xcode 15.4.1