Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helloworld job #44497

Closed
wants to merge 2 commits into from
Closed

add helloworld job #44497

wants to merge 2 commits into from

Conversation

blakef
Copy link
Contributor

@blakef blakef commented May 8, 2024

Summary: Adds the helloworld build job, that confirms we're able to build this simple application in CI.

Differential Revision: D57122797

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 8, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 9, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

Differential Revision: D57122797
@analysis-bot
Copy link

analysis-bot commented May 9, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,526,140 +7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,896,047 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 86dffb3
Branch: main

blakef added a commit to blakef/react-native that referenced this pull request May 9, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

Differential Revision: D57122797
blakef added a commit to blakef/react-native that referenced this pull request May 9, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 9, 2024
Summary:
Pull Request resolved: facebook#44497

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

Differential Revision: D57122797
blakef added a commit to blakef/react-native that referenced this pull request May 14, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 14, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 14, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 15, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 15, 2024
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

Summary:

Allows us to `yarn build ios` the helloworld app.

Changelog: [Internal]

Differential Revision: D57067038
Summary:

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 24, 2024
Summary:
Pull Request resolved: facebook#44497

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
blakef added a commit to blakef/react-native that referenced this pull request May 27, 2024
Summary:
Pull Request resolved: facebook#44497

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
blakef added a commit to blakef/react-native that referenced this pull request May 27, 2024
Summary:
Pull Request resolved: facebook#44497

Adds the helloworld build job, that confirms we're able to build this simple application in CI.

WARNING: Not ready for review now, still actively being worked on

Differential Revision: D57122797
@blakef blakef closed this May 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57122797

blakef added a commit to blakef/react-native that referenced this pull request May 30, 2024
…44497)

Summary:
Pull Request resolved: facebook#44497

Remove our `test_ios_template` job for `test_ios_helloworld`.

NOTE: There needs to be a followup to do the same in our Github Actions.

Changelog: [General][Changed] use helloworld instead of template for CI tests.

Differential Revision: D57122797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants