Optimize runtime initialization for native components with memoization

[admirsaheta]

Summary:

This pull request introduces a memoization optimization in the getNativeComponentAttributes function to avoid redundant runtime initialization for native components. It introduces a memoization cache (configCache) to store previously computed configurations, which are then utilized if available before computing a new one.

Changelog:

[INTERNAL|GENERAL] [ADDED] - Introduced memoization optimization to getNativeComponentAttributes function.

Test Plan:

No changes to user interface. The code has been tested locally to ensure that previously computed configurations are utilized when available, reducing redundant computations.

[github-actions]

	Fails
🚫	📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against 9e766f5

[NickGerleman]

@dmytrorykun does this change make sense?

[dmytrorykun]

@admirsaheta it is very likely that this optimization is already happening on a lower level of the framework. E.g. the only caller of getNativeComponentAttributes already uses cache internally. Are you seeing any reduction of the number of calls to UIManager.getViewManagerConfig with your changes?
cc @NickGerleman

[admirsaheta]

Good point @dmytrorykun, not really sure however I did fix my issue with patch-package locally in a project this way, see ref. below

[dmytrorykun]

@admirsaheta this error means that the LEGACY_RNCViewPager native component is not exported from native. Assuming you are on the old architecture, you should have either of the two:

1. LEGACY_RNCViewPager, a subclass of RCTViewManager, that has RCT_EXPORT_MODULE() in its implementation.
2. Some other RCTViewManager subclass that has RCT_EXPORT_MODULE(LEGACY_RNCViewPager) in its implementation.

I don't see how extra caching can fix this. Could that be some other change?

[efstathiosntonas]

@admirsaheta you must pass useNext={false} to the pager view component, latest release of pager-view is a mess…

[admirsaheta]

@admirsaheta you must pass useNext={false} to the pager view component, latest release of pager-view is a mess…

This fixes it as well! Thank you 👍
While I did observe improvements locally using this approach, your question about the reduction of calls to UIManager.getViewManagerConfig raises valid concerns about the effectiveness of this optimization in real-world scenarios, still would consider it good practice to avoid unnecassary re-inits each time it's called 👍

[dmytrorykun]

@admirsaheta

While I did observe improvements locally using this approach

Could you describe the improvements in more details?

still would consider it good practice to avoid unnecassary re-inits each time it's called

Re-inits of what exactly? Are you seeing getNativeComponentAttributes being called for the same component multiple times?

[admirsaheta]

Yes!

[dmytrorykun]

@admirsaheta could you please add more details, describe how you test this, and what is the improvement that you're seeing.