Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump SoLoader to 0.9.0 #29821

Closed
wants to merge 2 commits into from
Closed

bump SoLoader to 0.9.0 #29821

wants to merge 2 commits into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Sep 1, 2020 •
edited

Summary

SoLoader fixed crash on Android 4.1, and includes many improvements and fixes https://github.com/facebook/SoLoader/releases/tag/v0.9.0. Also Fresco 2.3.0 depends on it, and will create a PR soon to bump Fresco.

Changelog

[Android] [Changed] - Bump SoLoader to 0.9.0

Test Plan

CI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 1, 2020
@react-native-bot react-native-bot added the Platform: Android Android applications. label Sep 1, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,210,629 736
android hermes armeabi-v7a 6,859,809 752
android hermes x86 7,645,265 748
android hermes x86_64 7,536,221 752
android jsc arm64-v8a 9,369,470 752
android jsc armeabi-v7a 9,010,778 760
android jsc x86 9,232,194 756
android jsc x86_64 9,809,330 740

Base commit: 93e7a7a

@dulmandakh
Copy link
Contributor Author

@mdvacca please review and merge

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 93e7a7a

@fkgozali
Copy link
Contributor

fkgozali commented Sep 2, 2020

SoLoader fixed crash on Android 4.1, and includes many improvements and fixes

I think we target SDK 19 now, so that's Android 4.4 right? Do we still need this urgently?

Also Fresco 2.3.0 depends on it

Any particular reason to upgrade Fresco?

(I'm trying to understand the motivation for each upgrade for each of the dependencies we have)

@fkgozali fkgozali requested a review from hramos September 2, 2020 03:17
@dulmandakh
Copy link
Contributor Author

I think it's important to track FB dependencies because FB will use them internally from master, thus reduce parity between OSS and FB.

facebook-github-bot
facebook-github-bot reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mdvacca
mdvacca approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dulmandakh in 7465239.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 2, 2020
@facebook-github-bot
Copy link
Contributor

@mdvacca merged this pull request in 7465239.

kelset pushed a commit that referenced this pull request Nov 27, 2020
@dulmandakh @kelset
bump SoLoader to 0.9.0 (#29821)
864c76b 
Summary:
SoLoader fixed crash on Android 4.1, and includes many improvements and fixes https://github.com/facebook/SoLoader/releases/tag/v0.9.0. Also Fresco 2.3.0 depends on it, and will create a PR soon to bump Fresco.

## Changelog

[Android] [Changed] - Bump SoLoader to 0.9.0

Pull Request resolved: #29821

Test Plan: CI is green

Reviewed By: fkgozali

Differential Revision: D23477538

Pulled By: mdvacca

fbshipit-source-id: d2d982d5c5c84fc173dc66dfe069713ca90711a8
philippeauriach pushed a commit to philippeauriach/react-native that referenced this pull request May 5, 2021
@dulmandakh @philippeauriach
bump SoLoader to 0.9.0 (facebook#29821)
d00e27d 
Summary:
SoLoader fixed crash on Android 4.1, and includes many improvements and fixes https://github.com/facebook/SoLoader/releases/tag/v0.9.0. Also Fresco 2.3.0 depends on it, and will create a PR soon to bump Fresco.

## Changelog

[Android] [Changed] - Bump SoLoader to 0.9.0

Pull Request resolved: facebook#29821

Test Plan: CI is green

Reviewed By: fkgozali

Differential Revision: D23477538

Pulled By: mdvacca

fbshipit-source-id: d2d982d5c5c84fc173dc66dfe069713ca90711a8
@yungsters yungsters mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mdvacca mdvacca mdvacca approved these changes

@fkgozali fkgozali Awaiting requested review from fkgozali

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dulmandakh @analysis-bot @fkgozali @react-native-bot @facebook-github-bot @mdvacca