-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update projectRoot in launchPackager.bat #24115
Conversation
`launchPackager.bat` starts metro server but does not pass projectRoot to it so metro server starts in the wrong directory, It is because `startServerInNewWindow` pass `react-native` directory instead of `projectRoot` in the third argument of `spawn()` in `runAndroid.js`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @nazreinkaram in 9db347f. When will my fix make it into a release? | Upcoming Releases |
Summary: `launchPackager.bat` starts metro server but does not pass projectRoot to it. So metro server starts in the wrong directory, It is because `startServerInNewWindow` pass `react-native` directory instead of `projectRoot` in the third argument of `spawn()` in `runAndroid.js` Its working for people See facebook#23908 (comment) [Android] [Fixed] - projectRoot in launchPackager.bat Pull Request resolved: facebook#24115 Differential Revision: D14597101 Pulled By: cpojer fbshipit-source-id: fb4155b72e35062cfb41fe1b3ecca0e2b4e849ce
Summary: `launchPackager.bat` starts metro server but does not pass projectRoot to it. So metro server starts in the wrong directory, It is because `startServerInNewWindow` pass `react-native` directory instead of `projectRoot` in the third argument of `spawn()` in `runAndroid.js` Its working for people See #23908 (comment) [Android] [Fixed] - projectRoot in launchPackager.bat Pull Request resolved: #24115 Differential Revision: D14597101 Pulled By: cpojer fbshipit-source-id: fb4155b72e35062cfb41fe1b3ecca0e2b4e849ce
Summary
launchPackager.bat
starts metro server but does not pass projectRoot to it. So metro server starts in the wrong directory, It is becausestartServerInNewWindow
passreact-native
directory instead ofprojectRoot
in the third argument ofspawn()
inrunAndroid.js
Its working for people
See #23908 (comment)
Changelog
[Android] [Fixed] - projectRoot in launchPackager.bat
Test Plan