Skip to content

Commit efe5f62

Browse files
friederbluemlefacebook-github-bot
authored andcommittedJan 24, 2023
Fix whitespace and newline at EOF (#35939)
Summary: Just a couple of minor fixes in the `template/` folder: - Remove a trailing space in `rn_edit_text_material.xml` (this was the _only_ trailing space present in a newly generated RN project), which results in the check against the empty tree object failing: ``` $ git diff --check 4b825dc -- template/ template/android/app/src/main/res/drawable/rn_edit_text_material.xml:23: trailing whitespace. + <!-- ``` - Add missing newline at end of file in `.watchmanconfig` and `app.json` - Both are text files, and each line (including the last) is expected to end with a newline character (flagged by Git, and also visible as a warning on GitHub): <img width="369" alt="image" src="https://user-images.githubusercontent.com/743291/214195867-81c8e622-2130-44d4-bdaf-588e3510c109.png"> ## Changelog [GENERAL] [FIXED] - Fix whitespace and newline at EOF in template Pull Request resolved: #35939 Reviewed By: christophpurrer Differential Revision: D42698256 Pulled By: rshest fbshipit-source-id: 765fd41d4f501aec578755c754ea0ecb290ae6ca
1 parent 3876368 commit efe5f62

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed
 

‎packages/rn-tester/android/app/src/main/res/drawable/rn_edit_text_material.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
android:insetBottom="@dimen/abc_edit_text_inset_bottom_material">
2121

2222
<selector>
23-
<!--
23+
<!--
2424
This file is a copy of abc_edit_text_material (https://bit.ly/3k8fX7I).
2525
The item below with state_pressed="false" and state_focused="false" causes a NullPointerException.
2626
NullPointerException:tempt to invoke virtual method 'android.graphics.drawable.Drawable android.graphics.drawable.Drawable$ConstantState.newDrawable(android.content.res.Resources)'

‎template/_watchmanconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{}
1+
{}

‎template/android/app/src/main/res/drawable/rn_edit_text_material.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
android:insetBottom="@dimen/abc_edit_text_inset_bottom_material">
2121

2222
<selector>
23-
<!--
23+
<!--
2424
This file is a copy of abc_edit_text_material (https://bit.ly/3k8fX7I).
2525
The item below with state_pressed="false" and state_focused="false" causes a NullPointerException.
2626
NullPointerException:tempt to invoke virtual method 'android.graphics.drawable.Drawable android.graphics.drawable.Drawable$ConstantState.newDrawable(android.content.res.Resources)'

‎template/app.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"name": "HelloWorld",
33
"displayName": "HelloWorld"
4-
}
4+
}

0 commit comments

Comments
 (0)
Please sign in to comment.