Skip to content

Commit 9ba4dd8

Browse files
huntiefacebook-github-bot
authored andcommittedJan 30, 2025··
Delete Libraries/JSInspector (#49019)
Summary: Pull Request resolved: #49019 Removes the `JSInspector` class and its dependencies. - This was related to the legacy `ReactCommon/inspector/` subsystem (D4021490) — which added a compat layer from JavaScriptCore to CDP for an earlier version of Chrome debugging. - The JS components of this system (`JSInspector.js`, `NetworkAgent.js`) were added in D4021516. `ReactCommon/inspector/` has since been deleted and these components are no longer load bearing. - We intend to replace this logic (at least, the archaic `XHRInterceptor` behaviour, which worked at one point) with native debugger `Network` domain support in our C++ layer. **Changes** - Remove all modules under `Libraries/JSInspector/`. - Remove all `XHRInterceptor` call sites. - Remove the `JSInspector.registerAgent()` mount point in `setUpDeveloperTools.js`. - Exclude `Libraries/Core/setUp*` from `public-api-test` (these are side-effect setup files with no exported API). Changelog: [General][Breaking] - Remove legacy Libraries/JSInspector modules Reviewed By: christophpurrer Differential Revision: D68780147 fbshipit-source-id: 3d11cc89886a91055e6b69ac6f0609c288965801
1 parent accde40 commit 9ba4dd8

File tree

8 files changed

+1
-590
lines changed

8 files changed

+1
-590
lines changed
 

‎packages/react-native/Libraries/Core/setUpDeveloperTools.js

-4
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ declare var console: {[string]: $FlowFixMe};
1717
* You can use this module directly, or just require InitializeCore.
1818
*/
1919
if (__DEV__) {
20-
// Set up inspector
21-
const JSInspector = require('../JSInspector/JSInspector');
22-
JSInspector.registerAgent(require('../JSInspector/NetworkAgent').default);
23-
2420
// Note we can't check if console is "native" because it would appear "native" in JSC and Hermes.
2521
// We also can't check any properties that don't exist in the Chrome worker environment.
2622
// So we check a navigator property that's set to a particular value ("Netscape") in all real browsers.

‎packages/react-native/Libraries/JSInspector/InspectorAgent.js

-27
This file was deleted.

‎packages/react-native/Libraries/JSInspector/JSInspector.js

-33
This file was deleted.

‎packages/react-native/Libraries/JSInspector/NetworkAgent.js

-296
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.