From 8e48dc0555e0c3432a77d421b1e535d17f5933c8 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Tue, 7 Apr 2020 17:34:46 -0700 Subject: [PATCH] Rename analyticsTag -> internal_analyticsTag in ImageView component Summary: This diff renames the analyticsTag prop for the intenral_analyticsTag in ImageView component changelog: [internal] Creation of internal_analyticTag prop in ImageView, for now this prop is meant to be used internally. Reviewed By: TheSavior Differential Revision: D20904497 fbshipit-source-id: 2a28f746772ee0f9d657ec71549020c1f3e9d674 --- Libraries/Image/Image.android.js | 4 ++-- Libraries/Image/ImageProps.js | 4 ++-- .../com/facebook/react/views/image/ReactImageManager.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Libraries/Image/Image.android.js b/Libraries/Image/Image.android.js index 2ff257218c0e87..5e57732a855424 100644 --- a/Libraries/Image/Image.android.js +++ b/Libraries/Image/Image.android.js @@ -99,7 +99,7 @@ const ImageProps = { /** * Analytics Tag used by this Image */ - analyticTag: PropTypes.string, + internal_analyticTag: PropTypes.string, /** * Invoked on load start */ @@ -299,7 +299,7 @@ let Image = (props: ImagePropsType, forwardedRef) => { analyticTag !== null ? { ...nativeProps, - analyticTag: analyticTag, + internal_analyticTag: analyticTag, } : nativeProps; return ( diff --git a/Libraries/Image/ImageProps.js b/Libraries/Image/ImageProps.js index 08433eaa518264..8f8512e06cb861 100644 --- a/Libraries/Image/ImageProps.js +++ b/Libraries/Image/ImageProps.js @@ -69,9 +69,9 @@ export type ImageProps = {| accessible?: ?boolean, /** - * Analytics Tag used by this Image + * Internal prop to set an "Analytics Tag" that can will be set on the Image */ - analyticTag?: ?string, + internal_analyticTag?: ?string, /** * The text that's read by the screen reader when the user interacts with diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java index c3a689f27c56c9..e90301b6acea0b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageManager.java @@ -124,8 +124,8 @@ public void setBlurRadius(ReactImageView view, float blurRadius) { view.setBlurRadius(blurRadius); } - @ReactProp(name = "analyticTag") - public void setAnalyticsTag(ReactImageView view, @Nullable String analyticTag) { + @ReactProp(name = "internal_analyticTag") + public void setInternal_AnalyticsTag(ReactImageView view, @Nullable String analyticTag) { if (mCallerContextFactory != null) { view.updateCallerContext( mCallerContextFactory.getOrCreateCallerContext(