From 8721ee0a6b10e5bc8a5a95809aaa7b25dd5a6043 Mon Sep 17 00:00:00 2001 From: Max Ovtsin Date: Mon, 23 Mar 2020 13:42:09 -0700 Subject: [PATCH] Get ReactiveNative compiled with Clang 10 (#28362) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/28362 Fixed a few compilation errors emitted by Clang 10. Changelog: [iOS] [Fixed] - Get ready for Clang 10 Differential Revision: D20549970 fbshipit-source-id: dc36a85d90d3e43a05f045feb57c6ab6ded67da7 --- React/CxxBridge/RCTCxxBridge.mm | 2 +- ReactCommon/fabric/graphics/platform/ios/Color.cpp | 1 + .../turbomodule/core/platform/ios/RCTTurboModuleManager.mm | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm index 07b362a1ac23f8..884c61776e1aa1 100644 --- a/React/CxxBridge/RCTCxxBridge.mm +++ b/React/CxxBridge/RCTCxxBridge.mm @@ -777,7 +777,7 @@ - (void)registerExtraLazyModules #endif } -- (NSArray *)_initializeModules:(NSArray> *)modules +- (NSArray *)_initializeModules:(NSArray *)modules withDispatchGroup:(dispatch_group_t)dispatchGroup lazilyDiscovered:(BOOL)lazilyDiscovered { diff --git a/ReactCommon/fabric/graphics/platform/ios/Color.cpp b/ReactCommon/fabric/graphics/platform/ios/Color.cpp index f7100f98dcbc6a..dfde827886e203 100644 --- a/ReactCommon/fabric/graphics/platform/ios/Color.cpp +++ b/ReactCommon/fabric/graphics/platform/ios/Color.cpp @@ -6,6 +6,7 @@ */ #include "Color.h" +#include namespace facebook { namespace react { diff --git a/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm b/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm index 9036bdb385a7a1..9a671407102941 100644 --- a/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm +++ b/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm @@ -308,7 +308,7 @@ - (void)notifyAboutTurboModuleSetup:(const char *)name @"%@ has no setter or ivar for its bridge, which is not " "permitted. You must either @synthesize the bridge property, " "or provide your own setter method.", - RCTBridgeModuleNameForClass(strongModule)); + RCTBridgeModuleNameForClass([strongModule class])); } [performanceLogger attachRCTBridgeToRCTTurboModuleEnd:moduleName];