Skip to content

Commit 514ec41

Browse files
huntiefacebook-github-bot
authored andcommittedJan 28, 2025
Remove hanging reference to Remote Debugging endpoint on Android (#48996)
Summary: Pull Request resolved: #48996 Follows react-native-community/discussions-and-proposals#872. Changelog: [Android][Removed] - Remove `DevSupportManagerFactory.launchJSDevtools` API Reviewed By: hoxyq Differential Revision: D68766564 fbshipit-source-id: a9dad3a81ecc3fc03f056d4ccac8aa3e489cf242
1 parent 541e655 commit 514ec41

File tree

2 files changed

+0
-27
lines changed

2 files changed

+0
-27
lines changed
 

‎packages/react-native/ReactAndroid/api/ReactAndroid.api

-1
Original file line numberDiff line numberDiff line change
@@ -2095,7 +2095,6 @@ public class com/facebook/react/devsupport/DevServerHelper {
20952095
public fun getSourceUrl (Ljava/lang/String;)Ljava/lang/String;
20962096
public fun getWebsocketProxyURL ()Ljava/lang/String;
20972097
public fun isPackagerRunning (Lcom/facebook/react/devsupport/interfaces/PackagerStatusCallback;)V
2098-
public fun launchJSDevtools ()V
20992098
public fun openDebugger (Lcom/facebook/react/bridge/ReactContext;Ljava/lang/String;)V
21002099
public fun openInspectorConnection ()V
21012100
public fun openPackagerConnection (Ljava/lang/String;Lcom/facebook/react/devsupport/DevServerHelper$PackagerCommandListener;)V

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java

-26
Original file line numberDiff line numberDiff line change
@@ -426,32 +426,6 @@ public void isPackagerRunning(final PackagerStatusCallback callback) {
426426
}
427427
}
428428

429-
private String createLaunchJSDevtoolsCommandUrl() {
430-
return String.format(
431-
Locale.US,
432-
"http://%s/launch-js-devtools",
433-
mPackagerConnectionSettings.getDebugServerHost());
434-
}
435-
436-
public void launchJSDevtools() {
437-
Request request = new Request.Builder().url(createLaunchJSDevtoolsCommandUrl()).build();
438-
mClient
439-
.newCall(request)
440-
.enqueue(
441-
new Callback() {
442-
@Override
443-
public void onFailure(@NonNull Call call, @NonNull IOException e) {
444-
// ignore HTTP call response, this is just to open a debugger page and there is no
445-
// reason to report failures from here
446-
}
447-
448-
@Override
449-
public void onResponse(@NonNull Call call, @NonNull Response response) {
450-
// ignore HTTP call response - see above
451-
}
452-
});
453-
}
454-
455429
public String getSourceMapUrl(String mainModuleName) {
456430
return createBundleURL(mainModuleName, BundleType.MAP);
457431
}

0 commit comments

Comments
 (0)
Please sign in to comment.