From 2a5265dff7e654f57b43335804840692313f2a56 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Fri, 11 Mar 2022 02:47:27 -0800 Subject: [PATCH] fix(ios, flipper): update flipper sub-pods to support macCatalyst (#33406) Summary: Flipper-DoubleConversion and Flipper-Glog iOS pods received a build optimization a few versions back that pre-compiled the pods and references the xcframework slices Unfortunately, the pre-compile did not include macCatalyst slices, so this disabled support for flipper on macOS for react-native >0.65 lblasa has re-compiled the pods with the macCatalyst slices added See https://github.com/facebook/flipper/issues/3117 ## Changelog [iOS] [Fixed] - update Flipper pods to support re-enable macCatalyst Pull Request resolved: https://github.com/facebook/react-native/pull/33406 Test Plan: - [ ] The Flipper repo has a react-native test that appeared to work with these versions, CI should work here - [ ] Prove there is no regression, a flipper-enabled build test should work for simulator iOS target on arm64 - [ ] Prove there is no regression, a flipper-enabled build test should work for simulator iOS target on x86_64 mac - [ ] Prove there is no regression, a flipper-enabled build test should work for real device iOS target - [ ] To prove the issue is resolved, a build should be attempted for a macCatalyst target, and it should work. Reviewed By: cortinico Differential Revision: D34789654 Pulled By: lblasa fbshipit-source-id: 466803dd07b5820220512b7d7d760b94b8aa65f7 --- packages/rn-tester/Podfile.lock | 22 +++++++++++----------- scripts/react_native_pods.rb | 4 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/rn-tester/Podfile.lock b/packages/rn-tester/Podfile.lock index 4721993ddff08d..703accf393818d 100644 --- a/packages/rn-tester/Podfile.lock +++ b/packages/rn-tester/Podfile.lock @@ -14,7 +14,7 @@ PODS: - Flipper-Folly (~> 2.6) - Flipper-RSocket (~> 1.4) - Flipper-Boost-iOSX (1.76.0.1.11) - - Flipper-DoubleConversion (3.1.7) + - Flipper-DoubleConversion (3.2.0) - Flipper-Fmt (7.1.7) - Flipper-Folly (2.6.10): - Flipper-Boost-iOSX @@ -23,7 +23,7 @@ PODS: - Flipper-Glog - libevent (~> 2.1.12) - OpenSSL-Universal (= 1.1.1100) - - Flipper-Glog (0.3.9) + - Flipper-Glog (0.5.0.3) - Flipper-PeerTalk (0.0.4) - Flipper-RSocket (1.4.3): - Flipper-Folly (~> 2.6) @@ -710,7 +710,7 @@ PODS: - ReactCommon/turbomodule/core (= 1000.0.0) - ScreenshotManager (0.0.1): - RCT-Folly (= 2021.06.28.00-v2) - - React + - React-Core - SocketRocket (0.6.0) - Yoga (1.14.0) - YogaKit (1.18.1): @@ -723,10 +723,10 @@ DEPENDENCIES: - FBReactNativeSpec (from `../../React/FBReactNativeSpec`) - Flipper (= 0.125.0) - Flipper-Boost-iOSX (= 1.76.0.1.11) - - Flipper-DoubleConversion (= 3.1.7) + - Flipper-DoubleConversion (= 3.2.0) - Flipper-Fmt (= 7.1.7) - Flipper-Folly (= 2.6.10) - - Flipper-Glog (= 0.3.9) + - Flipper-Glog (= 0.5.0.3) - Flipper-PeerTalk (= 0.0.4) - Flipper-RSocket (= 1.4.3) - FlipperKit (= 0.125.0) @@ -884,13 +884,13 @@ SPEC CHECKSUMS: CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 DoubleConversion: 831926d9b8bf8166fd87886c4abab286c2422662 FBLazyVector: b81a2b70c72d8b0aefb652cea22c11e9ffd02949 - FBReactNativeSpec: 04dbf2a5d787706cace2f2af8ff3790333b761cd + FBReactNativeSpec: 4343c04fd79251fa1e5f2243b536df24009834f6 Flipper: 26fc4b7382499f1281eb8cb921e5c3ad6de91fe0 Flipper-Boost-iOSX: fd1e2b8cbef7e662a122412d7ac5f5bea715403c - Flipper-DoubleConversion: 57ffbe81ef95306cc9e69c4aa3aeeeeb58a6a28c + Flipper-DoubleConversion: 3d3d04a078d4f3a1b6c6916587f159dc11f232c4 Flipper-Fmt: 60cbdd92fc254826e61d669a5d87ef7015396a9b Flipper-Folly: 584845625005ff068a6ebf41f857f468decd26b3 - Flipper-Glog: 05579840e2750ec907ee2f81544f41ad76a7cae4 + Flipper-Glog: 7761f5362d23ead28c19afc2dd1d819f00e40df9 Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9 Flipper-RSocket: d9d9ade67cbecf6ac10730304bf5607266dd2541 FlipperKit: cbdee19bdd4e7f05472a66ce290f1b729ba3cb86 @@ -926,12 +926,12 @@ SPEC CHECKSUMS: React-RCTTest: 7cbcd615b1e74ad59c9ad4257e6c323482114173 React-RCTText: e9146b2c0550a83d1335bfe2553760070a2d75c7 React-RCTVibration: 9a73a3550a0ee184530341f91f9b85ad9cf3465a - React-rncore: 69bf49af24eafcd61f1e352c0cbff5cf17e70ed4 + React-rncore: b6e9b49eb1c7c045b98c77b1f94932e3c0be7cec React-runtimeexecutor: 4b0c6eb341c7d3ceb5e2385cb0fdb9bf701024f3 ReactCommon: 9607f2246289d573adcbd144c02c19ae5246d6a5 - ScreenshotManager: 2e9d0bca1461f67405d21ca06a609cb844c3fb3c + ScreenshotManager: 8a08e488cb533b83ebe069ad6109d9c1df9cea79 SocketRocket: fccef3f9c5cedea1353a9ef6ada904fde10d6608 - Yoga: c0d06f5380d34e939f55420669a60fe08b79bd75 + Yoga: faebdb8710c7e742c6ab99e14ed4270b8da27f1f YogaKit: f782866e155069a2cca2517aafea43200b01fd5a PODFILE CHECKSUM: 064c91fbb8ac895e453a791ebaaae5cfe9c8557d diff --git a/scripts/react_native_pods.rb b/scripts/react_native_pods.rb index b4f1b319c1fbca..3a168f2fd57894 100644 --- a/scripts/react_native_pods.rb +++ b/scripts/react_native_pods.rb @@ -137,10 +137,10 @@ def get_default_flags() def use_flipper!(versions = {}, configurations: ['Debug']) versions['Flipper'] ||= '0.125.0' versions['Flipper-Boost-iOSX'] ||= '1.76.0.1.11' - versions['Flipper-DoubleConversion'] ||= '3.1.7' + versions['Flipper-DoubleConversion'] ||= '3.2.0' versions['Flipper-Fmt'] ||= '7.1.7' versions['Flipper-Folly'] ||= '2.6.10' - versions['Flipper-Glog'] ||= '0.3.9' + versions['Flipper-Glog'] ||= '0.5.0.3' versions['Flipper-PeerTalk'] ||= '0.0.4' versions['Flipper-RSocket'] ||= '1.4.3' versions['OpenSSL-Universal'] ||= '1.1.1100'