This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Avoid app crashing on access token change #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The access token change event is broadcasted from AccessTokenTracker during app start, even before the react-native has fully initialized. This results in a RuntimeException while trying to retrive the JSModule from context. This is just a safe escape hatch to avoid app crashing. A more robust solution might be deferring the change event after the react-native initializes.
|
@chakrihacker Can you look into this ? Our app's top crash report on play store is resolved by this. |
|
Hi @syaau how to reproduce the issue in order to test?? |
|
@chakrihacker I have tried a lot of different things, but I haven't been able to reproduce it yet. I had the app crash on my Android device once during app start and that was it. But when I look at the play store data, around 0.5% of the users have reported this crash. And this is on the top of the list. |
|
OK, having try catch is always good 👋 , let the facebook devs take decision about it |
janicduplessis
approved these changes
May 18, 2020
|
I'm fine with that change, better than crashing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The access token change event is broadcasted from AccessTokenTracker
during app start, even before the react-native has fully initialized.
This results in a RuntimeException while trying to retrieve the
JSModule from context. This is just a safe escape hatch to avoid app
crashing. A more robust solution might be deferring the change event
after the react-native initializes.
Fixes #726