Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Update README.md #731

Merged
merged 1 commit into from May 18, 2020
Merged

Update README.md #731

merged 1 commit into from May 18, 2020

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Apr 8, 2020

https://developers.facebook.com/docs/ios/getting-started is confusing for us because:

In the following list, select the appropriate SDK for the language you will use in this app. If your app uses Swift, select SDK: Cocoapods. If your app uses Objective-C, select SDK: FB SDK

None of these are true in our case, but we do want to have SDK: Cocoapods pre-selected.

Further, 1.1 clarifies to only go as far as

  1. Install Cocoapods.

not further to install pod 'FBSDKCoreKit/Swift'.

https://developers.facebook.com/docs/ios/getting-started is confusing for us because:

'In the following list, select the appropriate SDK for the language you will use in this app. If your app uses Swift, select SDK: Cocoapods. If your app uses Objective-C, select SDK: FB SDK'

None of these are true in our case, but we do want to have 'SDK: Cocoapods' pre-selected.

Further, 1.1 clarifies to only go as far as '1. Install Cocoapods.' and not to install pod 'FBSDKCoreKit/Swift'.
@facebook-github-bot
Copy link

Hi @leotm!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@janicduplessis
Copy link
Contributor

Thanks! The instruction probably changed since the readme was last updated.

@janicduplessis janicduplessis merged commit 09ab122 into facebookarchive:master May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants