update facebook sdks to 5.8.0 for ios #659
Conversation
|
Hi michaelknoch! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| @@ -10,21 +10,21 @@ Pod::Spec.new do |s| | |||
| s.license = package['license'] | |||
| s.homepage = package['homepage'] | |||
| s.source = { :git => 'https://github.com/facebook/react-native-fbsdk.git', :tag => "v#{package['version']}" } | |||
| s.platform = :ios, '7.0' | |||
| s.platform = :ios, '8.0' | |||
There was a problem hiding this comment.
this is not needed, but i thought it makes sense because the deployment target of the fb sdks is set to 8.0
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Is there a release containing this update planned? Important for Catalyst support on Mac (and just good for keeping the SDK up to date!). |
|
Thanks @michaelknoch ! Sorry about the delay merging this |
Update facebook sdks to latest version
5.8.0which is already used on androidTest Plan:
We use this change in our app: