This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Fix sharing callback doesn't get called on Android. #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
Android ShareDialog callback doesn't work.
Used one
FBActivityEventListener
instance instead of multiple instances.Previously, we have one
FBActivityEventListener
for each module, and each one hasCallbackManager
.However, after sharing something, the first
CallbackManager
that got called will run this static callback (because we didn't register the callback to this manager), and makeAppCall
invalid.As a result, the
CallbackManager
for sharing module won't get called, because it has already been clearedTest Plan:
Could be tested with the share button on the example app.
Video here.