{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":110274488,"defaultBranch":"main","name":"pyre-check","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-11-10T17:31:36.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717387252.0","currentOid":""},"activityList":{"items":[{"before":"1b0a5336dcae64c977524eb4927455f0669d8d7a","after":"108811bea634c3b63c93041ffcf6bcd057066453","ref":"refs/heads/main","pushedAt":"2024-06-09T21:05:54.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Clean up from DataclassOptions.ml refactor\n\nSummary:\nWhen we created `dataclassOptions.ml` in order to make\nthe options visible to type check (which we did to address\nconformance tests that require throwing type errors on certain\nkinds of invalid dataclass definitions), we move the queries\nover.\n\nBut then we decoupled the actual options extraction from the queries,\nso that we could move them back to attributeResolution. This commit\nmakes that move. In the process I also eliminate the nested\n`ExtractDataclassOptions` namespace, which isn't really needed once\nwe get `Queries` out of the way, and avoid `open DataclassOptions` in\ndownstream code (when possible I try to avoid global `open`, it makes\nOCaml name resolution a little less obvious, especially if there are\na lot of big modules defining lots of symbols where collisions are\nlikely)\n\nReviewed By: migeed-z\n\nDifferential Revision: D58244121\n\nfbshipit-source-id: 6c33f2c53165803b0686cb5604720d2214daa57f","shortMessageHtmlLink":"Clean up from DataclassOptions.ml refactor"}},{"before":"0e274690293a748595297a8faa957a9a4a5819d8","after":"4f95b17b7549856f72a323e0c04001746987a4c8","ref":"refs/heads/gh-pages","pushedAt":"2024-06-08T08:39:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@1b0a5336dcae64c977524eb4927455f0669d8d7a π","shortMessageHtmlLink":"Deploying to gh-pages from @ 1b0a533 π"}},{"before":"8ad8d230de411ac1e84b7598ee1f85d09ba9492a","after":"1b0a5336dcae64c977524eb4927455f0669d8d7a","ref":"refs/heads/main","pushedAt":"2024-06-08T08:37:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Set the minimum chunk size to 1\n\nSummary:\n# Problem\nWe have noticed very low CPU usage on big machines.\nAfter investigation, it seems due to scheduler policies having a `minimum_chunk_size` of 100.\nWhen the number of task is low, say 1000, and number of workers is high (say 80), using the preferred chunk size would lead to a number of tasks per chunk below that threshold.\nThis ultimately leads the scheduler policy to pick a chunk count of 1, which disables parallelism entirely!\n\n# Solution\nLet's just set the minimum_chink_size to 1 for most map reduce operations.\n\nReviewed By: samwgoldman\n\nDifferential Revision: D58282862\n\nfbshipit-source-id: 1ea85bdf80b177bc77040fbfd479f4b3e82c0f3c","shortMessageHtmlLink":"Set the minimum chunk size to 1"}},{"before":"f2e04de174840e6d61e37e8ea4aa2375add8bf69","after":"0e274690293a748595297a8faa957a9a4a5819d8","ref":"refs/heads/gh-pages","pushedAt":"2024-06-08T01:27:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@8ad8d230de411ac1e84b7598ee1f85d09ba9492a π","shortMessageHtmlLink":"Deploying to gh-pages from @ 8ad8d23 π"}},{"before":"0a0e01e22def7558c3e253dcf6d087caee84ae75","after":"8ad8d230de411ac1e84b7598ee1f85d09ba9492a","ref":"refs/heads/main","pushedAt":"2024-06-08T01:25:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rename `Refinement` to `TypeInfo`\n\nSummary:\nThe name `refinement` suggests that this module is specifically\nabout type refinement, but that's not really the case - it's related,\nbut this module is actually where we store type context information.\n\nThe reason `Refinement` sort of made sense is that type refinement\nrequires putting the refined types *into* the type context, but that\ndoesn't make the type context \"about refinement\"; in reality, the\nlocal types (in the absense of refinement, just the normal types\ncoming from type inference!) are also stored here.\n\nAfter discussing with Jia, we think that the not-so-descriptive name\n`TypeInfo` is probably best for now; it's better to have a not very\ndescriptive name so that users look at the code and comments than\nto have a poorly chosen more-descriptive name that could be confusing.\n\n----\n\nNote that I also intend to move `Annotation.t`, which is also very poorly\nnamed (it isn't an annotation at all, it's a type plus some mutability info\nneeded for us to know how refinement should behave) into this module, which\nwill get rid of one of the worst-named types in Pyre and will potentially\nfree up the `Annotation.t` name for use if we ever want to model annotations\nusing an IR that is distinct from the \"fully resolved\" types in `Type.t`.\n\nThat will be a little trickier becuase I have to break a dependency cycle\nwhere TypeInfo depends on GlobalResolution depends on Annotation, but I'm\nhoping to tackle it in the next week or two.\n\nReviewed By: samwgoldman\n\nDifferential Revision: D58306709\n\nfbshipit-source-id: f5aba626c56344141dd0fab9d3673624c2875348","shortMessageHtmlLink":"Rename Refinement to TypeInfo"}},{"before":"7c25b94445591d304bc8b2a8b8853d09f7b18545","after":"f2e04de174840e6d61e37e8ea4aa2375add8bf69","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T21:46:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@0a0e01e22def7558c3e253dcf6d087caee84ae75 π","shortMessageHtmlLink":"Deploying to gh-pages from @ 0a0e01e π"}},{"before":"2e8fccb75f97dfeffccb5c2662779c6878fb59c8","after":"0a0e01e22def7558c3e253dcf6d087caee84ae75","ref":"refs/heads/main","pushedAt":"2024-06-07T21:44:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"rename forward_assign to forward_value_assignment and move it outside of forward_assignment\n\nSummary:\nChanges:\n\nThis diff moves the forward_assign helper function outside of forward_assignment to allow for reuse, and updates some variable/parameter names to be clearer.\n- explicit -> has_explicit_annotation\n- guide -> guide_annotation_type\n- original_annotation -> unwrapped_annotation_type (we get this by resolving the annotation expression to a type, and unwrap Final/Initvar/ClassVar)\n\nsemantically this should be a no-op\n\nMotivation:\n\nThe main reason I wanted to lift this particular piece of code out is that it contains the bulk of the logic for assignments, but crucially it also runs after we resolve the type for the RHS of the assignment.\n\nThis means that we can do whatever special typechecking/processing we need for the RHS of augmented assignments before calling this function.\n\nReviewed By: samwgoldman\n\nDifferential Revision: D58291288\n\nfbshipit-source-id: 0432f6d13a501e466c058de8933318b1e997ef75","shortMessageHtmlLink":"rename forward_assign to forward_value_assignment and move it outsideβ¦"}},{"before":"b867a1b46853b7b2434bc917f71e1781ca12bfb8","after":"7c25b94445591d304bc8b2a8b8853d09f7b18545","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T20:55:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@2e8fccb75f97dfeffccb5c2662779c6878fb59c8 π","shortMessageHtmlLink":"Deploying to gh-pages from @ 2e8fccb π"}},{"before":"57e04e095d218f27dce6045f65d175ae90e7c62f","after":"2e8fccb75f97dfeffccb5c2662779c6878fb59c8","ref":"refs/heads/main","pushedAt":"2024-06-07T20:54:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"delete empty contributing docs\n\nSummary:\nboth contributing.md and fb/contributing.md are blank, so I removed them.\n\nthe sidebar still has an entry for Contributing, but it links to a different place now.\n\nin the external site, it links to CONTRIBUTING.md in the repo: https://github.com/facebook/pyre-check/blob/main/CONTRIBUTING.md\n\nin the internal site, it links to the \"Development - Getting Started\" doc\n\nReviewed By: samwgoldman\n\nDifferential Revision: D58299990\n\nfbshipit-source-id: f06137bb3bb290c2a672bd761a03d5a25511b375","shortMessageHtmlLink":"delete empty contributing docs"}},{"before":"cee99a3e7a12c7f27107dc330b325f7a3ffc6729","after":"b867a1b46853b7b2434bc917f71e1781ca12bfb8","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T20:05:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@57e04e095d218f27dce6045f65d175ae90e7c62f π","shortMessageHtmlLink":"Deploying to gh-pages from @ 57e04e0 π"}},{"before":"5b82ed6432e715cb69512599c1139b8404fbfa72","after":"57e04e095d218f27dce6045f65d175ae90e7c62f","ref":"refs/heads/main","pushedAt":"2024-06-07T20:03:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"split literalTest\n\nSummary: splitting these up to make debugging easier\n\nReviewed By: stroxler\n\nDifferential Revision: D58258717\n\nfbshipit-source-id: bf30194bf7333e1ace56a8d90f7955239e56cd25","shortMessageHtmlLink":"split literalTest"}},{"before":"46f4f06768b49adf18edd7f25f17c54f805f0a26","after":"cee99a3e7a12c7f27107dc330b325f7a3ffc6729","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T17:49:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@7b6d471ef34ce5628584fad1c64da0d85d2d67cd π","shortMessageHtmlLink":"Deploying to gh-pages from @ 7b6d471 π"}},{"before":"7b6d471ef34ce5628584fad1c64da0d85d2d67cd","after":"5b82ed6432e715cb69512599c1139b8404fbfa72","ref":"refs/heads/main","pushedAt":"2024-06-07T17:47:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"rename `Refinement.{Unit -> LocalOrGlobal}`\n\nSummary:\nThe name `Refinement.Unit` doesn't tell us anything about what's being\nrefined. The answer is that it's always a local (including parameter) or\nglobal name; there's a map to handle attributes that might be refined\n(Pyre allows temporary refinement of any attribute and permanent refinement\nof final attributes).\n\nReviewed By: yangdanny97\n\nDifferential Revision: D58244280\n\nfbshipit-source-id: dfa5a464025c9942bf2897f4521ab8362986c11a","shortMessageHtmlLink":"rename Refinement.{Unit -> LocalOrGlobal}"}},{"before":"35281f0bb1f826af7fac653120d5b95245101bf7","after":"7b6d471ef34ce5628584fad1c64da0d85d2d67cd","ref":"refs/heads/main","pushedAt":"2024-06-07T17:43:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a test showing Pyre symbol collection fails on nested targets\n\nSummary:\nI was noticing that `UnannotatedGlobal.t` assumes you can unambigously indicate\nan assignment using a single tuple index, which suggested to me that the logic isn't\nproperly recursive. Looks like we just ignore assignment statements that don't match\nour expectations about structure 100% (even the outermost names are never bound).\n\nInterestingly I've never seen an actual bug report on this, so it might be low priority,\nbut it's still a limitation we ought to track. If a library ever *did* use this, we\nwould throw no-such-name errors all over the place in user code which would be problematic.\n\nReviewed By: yangdanny97\n\nDifferential Revision: D58241708\n\nfbshipit-source-id: bec564ec909cd2c6c3c2a12e1fc70d82c1a24422","shortMessageHtmlLink":"Add a test showing Pyre symbol collection fails on nested targets"}},{"before":"7aeb113399fa3f94c02d656ee2e60d7894285e66","after":"46f4f06768b49adf18edd7f25f17c54f805f0a26","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T08:02:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@35281f0bb1f826af7fac653120d5b95245101bf7 π","shortMessageHtmlLink":"Deploying to gh-pages from @ 35281f0 π"}},{"before":"cce71c3f26fd5beacf7574140d90a7c6fc37e042","after":"35281f0bb1f826af7fac653120d5b95245101bf7","ref":"refs/heads/main","pushedAt":"2024-06-07T08:00:07.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Implement equal on all abstract domains\n\nSummary:\nAbstract domains all have a less_equal operator, which means we can losely define `equal a b = less_equal a b && less_equal b a`.\nTherefore, let's just define a proper `equal` operator on all abstract domains.\n\nReviewed By: alexkassil\n\nDifferential Revision: D58235908\n\nfbshipit-source-id: 6a74701c789730b20b0ad3f73eeb9eff34760ccd","shortMessageHtmlLink":"Implement equal on all abstract domains"}},{"before":"b19eafd7f16f76370c2f981e5c2d7c915a8d889c","after":"7aeb113399fa3f94c02d656ee2e60d7894285e66","ref":"refs/heads/gh-pages","pushedAt":"2024-06-07T01:12:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@cce71c3f26fd5beacf7574140d90a7c6fc37e042 π","shortMessageHtmlLink":"Deploying to gh-pages from @ cce71c3 π"}},{"before":"f4d346e8b3debe68c3f414f54a014f1573fd839b","after":"cce71c3f26fd5beacf7574140d90a7c6fc37e042","ref":"refs/heads/main","pushedAt":"2024-06-07T01:10:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve function `verify_matching_partial_sinks` in modelParser.ml\n\nReviewed By: arthaud\n\nDifferential Revision: D58193833\n\nfbshipit-source-id: 9ea8b623c2852b32fa526807389bab95a8d8eca5","shortMessageHtmlLink":"Improve function verify_matching_partial_sinks in modelParser.ml"}},{"before":"2ff85aa850b5f441c5caadd15285c48e2a233c7a","after":"b19eafd7f16f76370c2f981e5c2d7c915a8d889c","ref":"refs/heads/gh-pages","pushedAt":"2024-06-06T20:15:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@f4d346e8b3debe68c3f414f54a014f1573fd839b π","shortMessageHtmlLink":"Deploying to gh-pages from @ f4d346e π"}},{"before":"270d56eba71a2bc948985dd03f08418aad9bbd64","after":"f4d346e8b3debe68c3f414f54a014f1573fd839b","ref":"refs/heads/main","pushedAt":"2024-06-06T20:13:20.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix spelling: Cannonical -> Canonical\n\nSummary:\nDanny caught this in an earlier commit, but restacking is pretty\nhard at this point so I'm just fixing forward.\n\nReviewed By: grievejia\n\nDifferential Revision: D58195497\n\nfbshipit-source-id: 5503544e1e0e73d6a4e9d3e1a423c07f41c2315a","shortMessageHtmlLink":"Fix spelling: Cannonical -> Canonical"}},{"before":"9bd8bf65fe9646f6f66dddb0a8123f6a5529459e","after":"270d56eba71a2bc948985dd03f08418aad9bbd64","ref":"refs/heads/main","pushedAt":"2024-06-06T20:07:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add typechecking for except clauses\n\nSummary:\nBased on the documentation for exception groups and try/catch, annotated `except` clauses should only catch `BaseException` and not `BaseExceptionGroup` even though the latter extends the former.\n\nThis diff updates the CFG to expose Try statements to the typechecker so we can check the exception handlers, and updates uninitializedLocalCheck to explicitly ignore them.\n\nWhen resolving the type annotation in the exception handler, I first try to parse it as a type name, and then if it fails I try to parse as an type variable expression to get some `type[T]` and extract the `T`.\n\nThis should align with the behavior of mypy and pyright since both of them allow type variables in this position.\n\nReviewed By: stroxler\n\nDifferential Revision: D58018874\n\nfbshipit-source-id: 969aff5240b2a131e2129aaf6b2b592230914f55","shortMessageHtmlLink":"add typechecking for except clauses"}},{"before":"d517d275ccc5f5dbb29dbc3e662eee2c9cd6d36e","after":"9bd8bf65fe9646f6f66dddb0a8123f6a5529459e","ref":"refs/heads/main","pushedAt":"2024-06-06T15:50:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Simplify the handling of errors when checking for partial sinks\n\nSummary: As titled. Following up on the discussions in D57913501.\n\nReviewed By: tianhan0\n\nDifferential Revision: D58232524\n\nfbshipit-source-id: 8fa0bb065ebee96dbe36e7f3b528207c7955e0b8","shortMessageHtmlLink":"Simplify the handling of errors when checking for partial sinks"}},{"before":"f7131061737d01907d6a4dbacb4bbd2653794f35","after":"d517d275ccc5f5dbb29dbc3e662eee2c9cd6d36e","ref":"refs/heads/main","pushedAt":"2024-06-05T22:48:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove the extra \"]\" when pretty printing triggered partial sinks\n\nReviewed By: alexkassil\n\nDifferential Revision: D58191474\n\nfbshipit-source-id: 29d6b50ba3d5562a7752c1fd67f31cb034367fad","shortMessageHtmlLink":"Remove the extra \"]\" when pretty printing triggered partial sinks"}},{"before":"487602a896669bfc8fc469f00a9a0a8ed71ce5f0","after":"f7131061737d01907d6a4dbacb4bbd2653794f35","ref":"refs/heads/main","pushedAt":"2024-06-05T20:08:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"cut over parsers for augmented assign\n\nSummary:\nthis diff cuts over all 3 parsers to generate AugmentedAssign AST nodes instead of Assign nodes with dunder methods.\n\nall the lowering and handling logic was added in previous diffs, so this one is changing the parsers and just fixing tests.\n\nReviewed By: stroxler\n\nDifferential Revision: D58109836\n\nfbshipit-source-id: afcd5fe038172c55cacf6c50a33726ad2060b81f","shortMessageHtmlLink":"cut over parsers for augmented assign"}},{"before":"1ef5fbccf3f7ae776e346fde77930610283d2888","after":"2ff85aa850b5f441c5caadd15285c48e2a233c7a","ref":"refs/heads/gh-pages","pushedAt":"2024-06-05T16:46:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploying to gh-pages from @ facebook/pyre-check@487602a896669bfc8fc469f00a9a0a8ed71ce5f0 π","shortMessageHtmlLink":"Deploying to gh-pages from @ 487602a π"}},{"before":"452038ff8a586d84bf846c0aa6cf5b3d1be12bc4","after":"487602a896669bfc8fc469f00a9a0a8ed71ce5f0","ref":"refs/heads/main","pushedAt":"2024-06-05T16:44:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rename parameters of function `RuleCoverage.from_rules`\n\nSummary:\nCurrently, it is unclear parameter `kind_coverage` is supposed to be the kind\ncoverage computed from the models -- it can be arbitrary kind coverage (e.g.,\nthe kind coverage computed from rules, which does not make sense). This diff\nhopefully avoids this confusion.\n\nReviewed By: arthaud\n\nDifferential Revision: D58154174\n\nfbshipit-source-id: 2404e8189a134dcd4a3a85f235f10a1ecaafbf4d","shortMessageHtmlLink":"Rename parameters of function RuleCoverage.from_rules"}},{"before":"f8cb3167dd00a02d8db39157b057392c89dacf95","after":"452038ff8a586d84bf846c0aa6cf5b3d1be12bc4","ref":"refs/heads/main","pushedAt":"2024-06-05T16:22:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move alternate_name_to_canonical_name_map\n\nSummary:\nContinuing to rearrange `type.ml` for readability and so that I can eventually use\nrecursive modules to have more readable data definitions. Here I'm just moving a flat\nmap of cannonical name mappings to live near `create_logic`, which is the only place\nit is used.\n\nReviewed By: yangdanny97\n\nDifferential Revision: D58171613\n\nfbshipit-source-id: 42f3a99625aa1e3c4fec1df31f3ad821e0b603cc","shortMessageHtmlLink":"Move alternate_name_to_canonical_name_map"}},{"before":"4454dba6210c31b83540dfd509b3ccc05b3e4f11","after":"f8cb3167dd00a02d8db39157b057392c89dacf95","ref":"refs/heads/main","pushedAt":"2024-06-05T12:48:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Create a Constructors module in `type.ml`\n\nSummary:\nI'm trying to make the `Type` module easier to understand\nand change. The biggest improvement we could make is to get rid of all\nthe `Record` modules, which have pretty unreadable names, and use recursive\nmodules instead.\n\nBut I'll need to do quite a bit of pushing code around first, because\ncurrently `type.ml` is freely mixing top-level helper functions with the\nmodules that \"shadow\" record modules like `Type.Callable`.\n\nA first step toward figuring out whether this is even feasible is to start\ngrouping together some of these top-level functions so they are namespaced\nand can be moved around, which also makes the dependency structure\nclearer.\n\nThis diff pulls all the \"smart constructor\" helpers into a `Constructors`\nmodule. I `include Constructors` at the bottom but inside of the body of\n`type.ml` all calls to the constructors are namespaced either explicitly\nor with a local `let open Constructors in` binding.\n\nReviewed By: grievejia\n\nDifferential Revision: D57991589\n\nfbshipit-source-id: a4eaf2509f87413a511a41c7e24c082f66c97796","shortMessageHtmlLink":"Create a Constructors module in type.ml"}},{"before":"ba8d8869fe67ad04aba8250b98e2cd5677ef3d76","after":"4454dba6210c31b83540dfd509b3ccc05b3e4f11","ref":"refs/heads/main","pushedAt":"2024-06-04T23:36:56.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Create modules for partial sink and triggered partial sinks in `sinks.ml`\n\nSummary: So that the readability can be improved at many places.\n\nReviewed By: arthaud\n\nDifferential Revision: D58106142\n\nfbshipit-source-id: 4daef5cf5a8aba32572331d9bae6c7e14077c1fa","shortMessageHtmlLink":"Create modules for partial sink and triggered partial sinks in `sinksβ¦"}},{"before":"f3d5139ca960011ba46168b496dc2b1ac09a2646","after":"ba8d8869fe67ad04aba8250b98e2cd5677ef3d76","ref":"refs/heads/main","pushedAt":"2024-06-04T23:31:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add test stubs for exception groups\n\nSummary:\ncopied from https://www.internalfb.com/code/fbsource/[327b4314287f38880cbc98aaf08ac22e50a99fd4]/fbcode/tools/pyre/stubs/typeshed/typeshed/stdlib/builtins.pyi?lines=2002\n\nwe need these stubs to write tests for except*\n\nReviewed By: stroxler\n\nDifferential Revision: D57996924\n\nfbshipit-source-id: c2ccdd16d0bf977345e23d2a94697d72825a8663","shortMessageHtmlLink":"add test stubs for exception groups"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYIrvMwA","startCursor":null,"endCursor":null}},"title":"Activity Β· facebook/pyre-check"}