New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive when mixing DEV and PROD builds #50

Merged

gaearon merged 1 commit into master from fix-false-positive

May 12, 2017

Contributor

gaearon commented May 12, 2017

When a library bundles a PROD build of prop-types, but it is used with a DEV version of React, we print a false positive error message:

Failed prop type: React.PropTypes type checking code is stripped in production

This fixes it by checking the secret even in the production build.
Fixes #38.


          Fix false positive when mixing DEV and PROD builds

118249e

gaearon merged commit d0fc940 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment