Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove envify in favor of loose-envify #204

Merged
merged 1 commit into from Feb 8, 2019

Conversation

autra
Copy link
Contributor

@autra autra commented Aug 9, 2018

Following the discussion in #203, this PR move loose-envify from dependencies to devDependencies.

I also took the opportunity to choose loose-envify over envify everywhere, as they are doing the same thing anyway. I have no opinion whether loose-envify is better than envify or not. Using yarn run test does not show any measurable difference in term of execution time, so I can switch back to envify if you prefer.

Closes #203.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@autra
Copy link
Contributor Author

autra commented Aug 9, 2018

We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

Oh yes. Should be ok now :-)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@autra

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb
Copy link
Collaborator

ljharb commented Feb 8, 2019

loose-envify's gotchas don't apply here, since we're not using env values in template literals, nor as anything but direct literal member access, so this seems fine.

@ljharb ljharb force-pushed the switch_envify_to_loose_envify branch from fdc5e80 to a5ce17a Compare February 8, 2019 22:30
@ljharb ljharb merged commit a5ce17a into facebook:master Feb 8, 2019
@autra autra deleted the switch_envify_to_loose_envify branch February 9, 2019 14:45
@autra
Copy link
Contributor Author

autra commented Feb 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants