New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert accidental breaking change for 15.5 #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great commit message - reading the code now. And let me know if there are any other checks I should do to verify this - pulling down the change and running fixtures, or anything like that. |
I don't really have any ideas for testing this except creating a project, dropping this version of |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of changes to unpack here but basically:
prop-types
package.PropTypesDevelopmentReact15
: When you depend onReact@15.PropTypes
in development, it runs type checks and shows warnings.PropTypesProductionReact15
: When you depend onReact@15.PropTypes
in production, everything is a no-op. It doesn't run the type checks but the code is still there. Calling validators doesn’t throw. This fixes PropTypes throwing errors in production? #17.PropTypesDevelopmentStandalone
andPropTypesProductionStandalone:
: When you depend onprop-types
, it runs type checks and shows warnings in development. Manually calling validators throws. (Just like we warned in earlier releases of React itself.) This is not a breaking change because migrating toprop-types
is an intentional decision, and requires you to update your code. We could call it out more explicitly but it’s explained in README.I also cherry-picked @aweary’s two commits for reducing the browserify bundle from #18 so that I could verify my changes. Production UMD bundle shows dead code is eliminated correctly.
When we release 16, we can drop the
React15
tests, delete thefactory
indirection and bump the major version.