Support validation when hasOwnProperty is not in prototype #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
May 29, 2018
checkPropTypes.js
Outdated
| @@ -28,7 +28,7 @@ if (process.env.NODE_ENV !== 'production') { | |||
| function checkPropTypes(typeSpecs, values, location, componentName, getStack) { | |||
| if (process.env.NODE_ENV !== 'production') { | |||
| for (var typeSpecName in typeSpecs) { | |||
| if (typeSpecs.hasOwnProperty(typeSpecName)) { | |||
| if (Object.prototype.hasOwnProperty.call(typeSpecs, typeSpecName)) { | |||
There was a problem hiding this comment.
The next robustness step is to do var has = Object.prototypr.hasOwnProperty at module scope, and then here, do has.call.
|
I moved the declaration to module scope now (amended the commit) and added a test for objects with a |
|
Thanks for this fix! Running into this as well. Is there a reason it sits open? |
|
@mhuggins It is ready to be merged from my side (aside from the merge conflicts now). |
|
Rebased this; it's partially addressed by #112 but still includes tests and a fix. |
|
Thanks, guys! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the
Warning: Failed prop type: propValue.hasOwnProperty is not a functionwarning whenhasOwnPropertyis not defined in the prototype chain.See #183 for details.
delete Object.prototype.hasOwnPropertybeing a thing. I did not quite get this comment, so this solution might not work because of that. Just close this PR in that case.PropTypes.shape({ q: PropTypes.objectOf(PropTypes.string) })I pointed out inobjectOfshould not requirehasOwnPropertyto be a function #183 (comment), as I didn't know where to place them