Export resetWarningCache

[patsplat]

When testing code using PropTypes, warnings fail unexpectedly due to caching behavior. It would be useful for resetWarningCache to be part of the publicly exported API.

• Added test for current caching behavior of PropTypes.checkPropTypes
• Added test for new reset function PropTypes.checkPropTypes.resetWarningCache
• Implemented PropTypes.checkPropTypes.resetWarningCache
• Documented PropTypes.checkPropTypes.resetWarningCache

[ljharb]

This is excellent; in our tests we never want to suppress warnings, so we’d run this before every test.

[patsplat]

Thanks for the 👍

This addition is also intended to make spying console.error for expected warnings reliable. Currently mocha --watch fails on rebuilds.

[ljharb]

cc @aweary

[patsplat]

Hi! Any updates or feedback on this PR?

[patsplat]

Closing due to inactivity. If you are interested in this feel free to reopen.

[ljharb]

Please reopen this; inactivity is irrelevant.

[patsplat]

@ljharb any suggestions on next steps for this PR?

[ljharb]

Unfortunately we have to wait for the maintainers to take a look.

[gaearon]

Is there any specific reason it's on checkPropTypes, and not on the PropTypes object itself?

I'm worried if attaching things to functions can mess with uglify/rollup "pure" code detection. Not that it matters for this piece of code but still.

[ljharb]

It does seem useful to me to have it tucked away somewhere - devs are less likely to casually use it that way.

[patsplat]

Implemented on checkPropTypes as that is the unit whose state is modified.

[patsplat]

Happy if library maintainers want to move the interface around, but figured it could start in the most naive spot first.

[uniphil]

This would be awesome! It would make eg. https://github.com/ratehub/check-prop-types obsolete, which would make me (its creator) very happy.

[patsplat]

@gaearon changed the public interface to PropTypes.resetWarningCache. Still need to reach inside checkPropTypes to clear the cache.

Are there any other recommended changes?

[uniphil]

💃

[patsplat]

Thanks @ljharb !